Chromium Code Reviews Chromium Code Reviews
Issue 15969014:
History: Update managed user history page (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/resources/history/history.html |
| diff --git a/chrome/browser/resources/history/history.html b/chrome/browser/resources/history/history.html |
| index 14e35f75fb7dcc3745d555c1f952440a865e2eba..ea08d4609b8e2bfb3caca48337941c624f7fabdf 100644 |
| --- a/chrome/browser/resources/history/history.html |
| +++ b/chrome/browser/resources/history/history.html |
| @@ -61,40 +61,49 @@ |
| <body i18n-values=".style.fontFamily:fontfamily"> |
| </if> |
| -<div class="page"> |
| +<div class="page" id="page"> |
|
markusheintz_
2013/06/05 14:00:06
Please make id the first attribute.
Sergiu
2013/06/05 20:18:41
Done.
|
| <header> |
| <h1 i18n-content="history"></h1> |
| <div id="search-form" class="search-field-container"> |
| <input type="search" id="search-field" required> |
| <input type="submit" id="search-button" i18n-values="value:searchButton"> |
| </div> |
| - </header> |
| - |
| - <div id="filter-controls" hidden> |
| - <button id="range-today" i18n-content="rangeToday" disabled> |
| - </button> |
| - <button id="range-previous" disabled> |
| - <img src="../disclosure_triangle_small.png" |
| - i18n-values="alt:rangePrevious"> |
| - </button> |
| - <button id="range-next" disabled> |
| - <img src="../disclosure_triangle_small.png" i18n-values="alt:rangeNext"> |
| - </button> |
| - <div id="display-filter-controls"> |
| - <label> |
| - <input type="checkbox" id="group-by-domain" name="group-by-domain"> |
| - <span i18n-content="groupByDomainLabel"></span> |
| - </label> |
| - <label> |
| - <span i18n-content="rangeLabel"></span> |
| - <select id="timeframe-filter"> |
| - <option i18n-content="rangeAllTime" value="0"></option> |
| - <option i18n-content="rangeWeek" value="1"></option> |
| - <option i18n-content="rangeMonth" value="2"></option> |
| - </select> |
| - </label> |
| + <div id="filter-controls"> |
| + <button id="range-today" i18n-content="rangeToday" disabled> |
| + </button> |
|
James Hawkins
2013/06/04 18:22:05
Can this fit on the line above?
Sergiu
2013/06/05 11:21:37
Done.
|
| + <button id="range-previous" disabled> |
| + <img src="../disclosure_triangle_small.png" |
| + i18n-values="alt:rangePrevious"> |
| + </button><button id="range-next" disabled> |
|
James Hawkins
2013/06/04 18:22:05
Why is this next button not on a new line?
Sergiu
2013/06/05 11:21:37
Well, this is related to the problem of space betw
|
| + <img src="../disclosure_triangle_small.png" i18n-values="alt:rangeNext"> |
| + </button> |
| + <div id="display-filter-controls"> |
| + <div class="display-filter-button"> |
| + <label for="timeframe-filter-all"> |
| + <input type="radio" id="timeframe-filter-all" |
|
James Hawkins
2013/06/04 18:22:05
nit: IDs should be the first attribute.
Sergiu
2013/06/05 11:21:37
Done.
|
| + name="timeframe-filter" value="0" checked> |
| + <span i18n-content="rangeAllTime" class="first-button-component"> |
| + </span> |
| + </label> |
| + </div> |
| + <div class="display-filter-button"> |
| + <label for="timeframe-filter-week"> |
| + <input type="radio" id="timeframe-filter-week" |
| + name="timeframe-filter" value="1"> |
| + <span i18n-content="rangeWeek"></span> |
| + </label> |
| + </div> |
| + <div class="display-filter-button"> |
| + <label for="timeframe-filter-month"> |
| + <input type="radio" id="timeframe-filter-month" |
| + name="timeframe-filter" value="2"> |
| + <span i18n-content="rangeMonth" class="last-button-component"> |
| + </span> |
| + </label> |
| + </div> |
| + </div> |
| </div> |
| - </div> |
| + </header> |
| <if expr="not is_android"> |
| <div id="other-devices" class="other-devices"></div> |
| </if> |
