Issue 159689: linux: don't call NPP_SetWindow if the width/height is <= 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159689: linux: don't call NPP_SetWindow if the width/height is <= 0 (Closed)

Created:
11 years, 4 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: don't call NPP_SetWindow if the width/height is <= 0 This follows what Mozilla does, see https://bugzilla.mozilla.org/show_bug.cgi?id=108347 This fixes the gmail+flash = 100% CPU. BUG=16844 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22165

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl_gtk.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Wow, awesome. LGTM, and how'd you find the Mozilla bug?

11 years, 4 months ago (2009-07-31 15:49:41 UTC) #2

piman

11 years, 4 months ago (2009-07-31 18:27:14 UTC) #3

On Fri, Jul 31, 2009 at 8:49 AM, <evan@chromium.org> wrote:
> Wow, awesome. =A0LGTM, and how'd you find the Mozilla bug?

The bug is mentioned in the Mozilla code, right as it tests for that
condition right before calling NPP_SetWindow.

>
> http://codereview.chromium.org/159689
>

Expand Messages | Collapse Messages