Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 15968014: Prepare gyp_chromium for moving Source/core/core.gyp/core.gyp up a directory (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, jamesr, (unused - use chromium)
Visibility:
Public.

Description

Prepare gyp_chromium for moving Source/core/core.gyp/core.gyp up a directory This adds a new import path for pymod_do_main (and removes an old one). After core.gyp moves up a directory, the old path can be removed. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204115

Patch Set 1 : Re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/gyp_chromium View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
7 years, 6 months ago (2013-06-04 21:05:46 UTC) #1
adamk
See https://codereview.chromium.org/16357021/ for the Blink side of this change.
7 years, 6 months ago (2013-06-04 21:10:46 UTC) #2
abarth-chromium
LGTM
7 years, 6 months ago (2013-06-04 21:11:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/15968014/3001
7 years, 6 months ago (2013-06-04 21:17:30 UTC) #4
adamk
7 years, 6 months ago (2013-06-05 01:20:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r204115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698