chrome/chrome_browser.gypi - Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java ('K') | « chrome/chrome.gyp ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index cd435cc3a57bfa3cc3b30557b6e94437ca6fa359..21814c9ce2eeadaa9c1dad3dc9f854c33fb00205 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1928,6 +1928,7 @@

'android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java',

'android/java/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfoBarDelegate.java',

'android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java',

+ 'android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java',

'android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfoBar.java',

'android/java/src/org/chromium/chrome/browser/invalidation/InvalidationServiceFactory.java',

'android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java',