Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: components/infobars/core/infobar_delegate.h

Issue 1596713003: Discourage creation of Java infobars without InfoBarDelegates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/infobars/core/BUILD.gn ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/infobars/core/infobar_delegate.h
diff --git a/components/infobars/core/infobar_delegate.h b/components/infobars/core/infobar_delegate.h
index 1a9931b99f146892252b076fadce7ddbf33fe987..a33cf618e79242dc4240e676537e112ff72417e7 100644
--- a/components/infobars/core/infobar_delegate.h
+++ b/components/infobars/core/infobar_delegate.h
@@ -63,6 +63,8 @@ class InfoBarDelegate {
// Unique identifier for every InfoBarDelegate subclass.
// KEEP IN SYNC WITH THE InfoBarIdentifier ENUM IN histograms.xml.
// NEW VALUES MUST BE APPENDED AND AVOID CHANGING ANY PRE-EXISTING VALUES.
+ // A Java counterpart will be generated for this enum.
+ // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.infobar
enum InfoBarIdentifier {
INVALID = -1,
TEST_INFOBAR = 0,
@@ -124,7 +126,9 @@ class InfoBarDelegate {
SHOW_PASSKIT_INFOBAR_ERROR_DELEGATE = 56,
READER_MODE_INFOBAR_DELEGATE = 57,
SYNC_ERROR_INFOBAR_DELEGATE = 58,
- UPGRADE_INFOBAR_DELEGATE = 59
+ UPGRADE_INFOBAR_DELEGATE = 59,
+ CHROME_WINDOW_ERROR = 60,
+ CONFIRM_DANGEROUS_DOWNLOAD = 61,
};
// Describes navigation events, used to decide whether infobars should be
« no previous file with comments | « components/infobars/core/BUILD.gn ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698