Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: pkg/analyzer/tool/summary/generate.dart

Issue 1596703002: Generate code UnlinkedConst / UnlinkedConstOperation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/tool/summary/idl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/summary/generate.dart
diff --git a/pkg/analyzer/tool/summary/generate.dart b/pkg/analyzer/tool/summary/generate.dart
index a68a451f7d4a0e0b51461071d8976e666f0f1106..792b8ac86bab455dcdc4c50c356c0dd1bab19ba0 100644
--- a/pkg/analyzer/tool/summary/generate.dart
+++ b/pkg/analyzer/tool/summary/generate.dart
@@ -88,8 +88,12 @@ class _CodeGenerator {
if (type.isList) {
if (_idl.classes.containsKey(type.typeName)) {
// List of classes is ok
+ } else if (_idl.enums.containsKey(type.typeName)) {
+ // List of enums is ok
} else if (type.typeName == 'int') {
// List of ints is ok
+ } else if (type.typeName == 'double') {
+ // List of doubles is ok
} else if (type.typeName == 'String') {
// List of strings is ok
} else {
@@ -371,8 +375,14 @@ class _CodeGenerator {
String itemCode = 'b.finish(fbBuilder)';
String listCode = '$valueName.map((b) => $itemCode).toList()';
writeCode = '$offsetName = fbBuilder.writeList($listCode);';
+ } else if (_idl.enums.containsKey(fieldType.typeName)) {
+ String itemCode = 'b.index';
+ String listCode = '$valueName.map((b) => $itemCode).toList()';
+ writeCode = '$offsetName = fbBuilder.writeListInt32($listCode);';
} else if (fieldType.typeName == 'int') {
writeCode = '$offsetName = fbBuilder.writeListInt32($valueName);';
+ } else if (fieldType.typeName == 'double') {
+ writeCode = '$offsetName = fbBuilder.writeListFloat64($valueName);';
} else {
assert(fieldType.typeName == 'String');
String itemCode = 'fbBuilder.writeString(b)';
@@ -496,12 +506,18 @@ class _CodeGenerator {
if (typeName == 'int') {
String itemCode = 'const fb.Int32Reader()';
readCode = 'const fb.ListReader<int>($itemCode)';
+ } else if (typeName == 'double') {
+ readCode = 'const fb.Float64ListReader()';
} else if (typeName == 'String') {
String itemCode = 'const fb.StringReader()';
readCode = 'const fb.ListReader<String>($itemCode)';
- } else {
+ } else if (_idl.classes.containsKey(typeName)) {
String itemCode = '$typeName>(const _${typeName}Reader()';
readCode = 'const fb.ListReader<$itemCode)';
+ } else {
+ assert(_idl.enums.containsKey(typeName));
+ String itemCode = 'const _${typeName}Reader()';
+ readCode = 'const fb.ListReader<$typeName>($itemCode)';
}
} else if (typeName == 'bool') {
readCode = 'const fb.BoolReader()';
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/tool/summary/idl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698