Add skiaBenchmarking.getOps()

content/renderer/skia_benchmarking_extension_unittest.cc

Index: content/renderer/skia_benchmarking_extension_unittest.cc
diff --git a/content/renderer/skia_benchmarking_extension_unittest.cc b/content/renderer/skia_benchmarking_extension_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3e891519c3fbabd96d50baf073a48ba69971c544
--- /dev/null
+++ b/content/renderer/skia_benchmarking_extension_unittest.cc
@@ -0,0 +1,94 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/skia_benchmarking_extension.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/skia/include/core/SkCanvas.h"
+#include "third_party/skia/include/core/SkGraphics.h"
+#include "third_party/skia/src/utils/debugger/SkDebugCanvas.h"
+#include "third_party/skia/src/utils/debugger/SkDrawCommand.h"
+
+// FIXME: loose info paramter test.
+#define EXPECT_INFO(info, key) do { \
+    ASSERT_TRUE(info != NULL); \
+    bool key##_found = false; \
+    for (int i = 0; i < info->count(); ++i) { \
+      const SkString* info_str = (*info)[i]; \
+      ASSERT_TRUE(info_str != NULL); \
+      if (strstr(info_str->c_str(), #key ) != NULL) { \
+        key##_found = true; \
+        break; \
+      } \
+    } \
+    EXPECT_TRUE(key##_found); \
+  } while (0)

[piman, 2013/06/20 18:30:52]

nit: Why the need to make this a macro? Can't it be a helper function?

[f(malita), 2013/06/20 18:48:15]

The only reason I went with a macro was to be able to pass a token-pasted
parameter to EXPECT_TRUE, and get a more informative message in case of failure
(containing the actual missing parameter name). Maybe it's not worth it, or
maybe there's a better way?

[piman, 2013/06/20 19:35:03]

gtest.h defines the AssertionResult class which looks like it would fit the role
(there's a few examples there).

[f(malita), 2013/06/20 20:05:20]

That's perfect, thanks!

+
+namespace content {
+
+TEST(SkiaBenchmarkingExtensionTest, SkDebugCanvas) {
+  SkGraphics::Init();
+
+  // Prepare canvas and resources.
+  SkDebugCanvas canvas(100, 100);
+  SkPaint red_paint;
+  red_paint.setColor(SkColorSetARGB(255, 255, 0, 0));
+  SkRect fullRect = SkRect::MakeWH(SkIntToScalar(100), SkIntToScalar(100));
+  SkRect fillRect = SkRect::MakeXYWH(SkIntToScalar(25), SkIntToScalar(25),
+                                     SkIntToScalar(50), SkIntToScalar(50));
+
+  // Draw a trivial scene.
+  canvas.save(SkCanvas::kMatrixClip_SaveFlag);
+  canvas.clipRect(fullRect, SkRegion::kIntersect_Op, false);
+  canvas.translate(SkIntToScalar(10), SkIntToScalar(10));
+  canvas.scale(SkIntToScalar(2), SkIntToScalar(2));
+  canvas.drawRect(fillRect, red_paint);
+  canvas.restore();
+
+  // Verify the recorded commands.
+  DrawType cmd;
+  int idx = 0;
+  ASSERT_EQ(canvas.getSize(), 6);
+
+  ASSERT_TRUE(canvas.getDrawCommandAt(idx) != NULL);
+  cmd = canvas.getDrawCommandAt(idx)->getType();
+  EXPECT_EQ(cmd, SAVE);
+  EXPECT_STREQ(SkDrawCommand::GetCommandString(cmd), "Save");
+  EXPECT_INFO(canvas.getCommandInfo(idx), SaveFlags);
+
+  ASSERT_TRUE(canvas.getDrawCommandAt(++idx) != NULL);
+  cmd = canvas.getDrawCommandAt(idx)->getType();
+  EXPECT_EQ(cmd, CLIP_RECT);
+  EXPECT_STREQ(SkDrawCommand::GetCommandString(cmd), "Clip Rect");
+  EXPECT_INFO(canvas.getCommandInfo(idx), SkRect);
+  EXPECT_INFO(canvas.getCommandInfo(idx), Op);
+  EXPECT_INFO(canvas.getCommandInfo(idx), doAA);
+
+  ASSERT_TRUE(canvas.getDrawCommandAt(++idx) != NULL);
+  cmd = canvas.getDrawCommandAt(idx)->getType();
+  EXPECT_EQ(cmd, TRANSLATE);
+  EXPECT_STREQ(SkDrawCommand::GetCommandString(cmd), "Translate");
+  EXPECT_INFO(canvas.getCommandInfo(idx), dx);
+  EXPECT_INFO(canvas.getCommandInfo(idx), dy);
+
+  ASSERT_TRUE(canvas.getDrawCommandAt(++idx) != NULL);
+  cmd = canvas.getDrawCommandAt(idx)->getType();
+  EXPECT_EQ(cmd, SCALE);
+  EXPECT_STREQ(SkDrawCommand::GetCommandString(cmd), "Scale");
+  EXPECT_INFO(canvas.getCommandInfo(idx), sx);
+  EXPECT_INFO(canvas.getCommandInfo(idx), sy);
+
+  ASSERT_TRUE(canvas.getDrawCommandAt(++idx) != NULL);
+  cmd = canvas.getDrawCommandAt(idx)->getType();
+  EXPECT_EQ(cmd, DRAW_RECT);
+  EXPECT_STREQ(SkDrawCommand::GetCommandString(cmd), "Draw Rect");
+  EXPECT_INFO(canvas.getCommandInfo(idx), SkRect);
+
+  ASSERT_TRUE(canvas.getDrawCommandAt(++idx) != NULL);
+  cmd = canvas.getDrawCommandAt(idx)->getType();
+  EXPECT_EQ(cmd, RESTORE);
+  EXPECT_STREQ(SkDrawCommand::GetCommandString(cmd), "Restore");
+}
+
+} // namespace content