Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2767)

Unified Diff: skia/skia.gyp

Issue 15967010: Add skiaBenchmarking.getOps() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/skia.gyp
diff --git a/skia/skia.gyp b/skia/skia.gyp
index cc80423cb8559fad8a3b67a63fc539b07811d8bb..8c32b6a1b7a430da0817e3ae1ad6df9f5e0f8c9c 100644
--- a/skia/skia.gyp
+++ b/skia/skia.gyp
@@ -8,6 +8,12 @@
'target_name': 'skia',
'type': '<(component)',
'variables': {
+ # We have to nest variables inside variables so that they can be overridden
nduca 2013/06/11 23:52:13 confused, this wont be always on? If thats the cas
f(malita) 2013/06/12 13:32:37 Alright... was hesitant to go there, yet :) I don'
+ # through GYP_DEFINES.
+ 'variables': {
+ 'enable_graphics_context_annotations%': 0,
+ },
+
'conditions': [
['OS== "ios"', {
'skia_support_gpu': 0,
@@ -21,6 +27,8 @@
# These two set the paths so we can include skia/gyp/core.gypi
'skia_src_path': '../third_party/skia/src',
'skia_include_path': '../third_party/skia/include',
+
+ 'enable_graphics_context_annotations%': '<(enable_graphics_context_annotations)',
},
'includes': [
@@ -129,6 +137,12 @@
'../third_party/skia/include/utils/mac/SkCGUtils.h',
'../third_party/skia/include/utils/SkDeferredCanvas.h',
'../third_party/skia/include/utils/SkMatrix44.h',
+ '../third_party/skia/src/utils/debugger/SkDebugCanvas.cpp',
+ '../third_party/skia/src/utils/debugger/SkDebugCanvas.h',
+ '../third_party/skia/src/utils/debugger/SkDrawCommand.cpp',
+ '../third_party/skia/src/utils/debugger/SkDrawCommand.h',
+ '../third_party/skia/src/utils/debugger/SkObjectParser.cpp',
+ '../third_party/skia/src/utils/debugger/SkObjectParser.h',
'../third_party/skia/src/utils/mac/SkCreateCGImageRef.cpp',
'../third_party/skia/src/utils/SkBase64.cpp',
'../third_party/skia/src/utils/SkBase64.h',
@@ -548,6 +562,12 @@
'-Wstring-conversion',
],
}],
+ ['enable_graphics_context_annotations == 1', {
+ 'defines': [
+ # Enable pretty-printing of certain Skia structures.
+ 'SK_DEVELOPER',
nduca 2013/06/11 23:52:13 what implications does this have?
f(malita) 2013/06/12 13:32:37 It mostly enables toString methods on some Skia ty
+ ],
+ }],
],
'dependencies': [
'skia_opts',

Powered by Google App Engine
This is Rietveld 408576698