Add skiaBenchmarking.getOps()

skia/skia.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'skia',
       'type': '<(component)',
       'variables': {
+        # We have to nest variables inside variables so that they can be overridden

[nduca, 2013/06/11 23:52:13]

confused, this wont be always on? If thats the case, we're doing something
wrong... this system should be always-compiled in, not
on-in-some-builds-but-not-others...

[f(malita), 2013/06/12 13:32:37]

Alright... was hesitant to go there, yet :) I don't expect the annotations
framework to have a runtime impact, but I'm somewhat wary of SK_DEVELOPER below.

+        # through GYP_DEFINES.
+        'variables': {
+          'enable_graphics_context_annotations%': 0,
+        },
+
         'conditions': [
           ['OS== "ios"', {
             'skia_support_gpu': 0,
           }, {
             'skia_support_gpu': 1,
           }],
         ],
 
         'optimize': 'max',
 
         # These two set the paths so we can include skia/gyp/core.gypi
         'skia_src_path': '../third_party/skia/src',
         'skia_include_path': '../third_party/skia/include',
+
+        'enable_graphics_context_annotations%': '<(enable_graphics_context_annotations)',
       },
 
       'includes': [
         '../third_party/skia/gyp/core.gypi',
         '../third_party/skia/gyp/effects.gypi',
       ],
 
       'sources': [
         # this should likely be moved into src/utils in skia
         '../third_party/skia/src/core/SkFlate.cpp',
@@ skipping 88 matching lines @@
         #'../third_party/skia/src/ports/SkXMLParser_expat.cpp',
         #'../third_party/skia/src/ports/SkXMLParser_tinyxml.cpp',
         #'../third_party/skia/src/ports/SkXMLPullParser_expat.cpp',
 
         '../third_party/skia/src/sfnt/SkOTUtils.cpp',
         '../third_party/skia/src/sfnt/SkOTUtils.h',
 
         '../third_party/skia/include/utils/mac/SkCGUtils.h',
         '../third_party/skia/include/utils/SkDeferredCanvas.h',
         '../third_party/skia/include/utils/SkMatrix44.h',
+        '../third_party/skia/src/utils/debugger/SkDebugCanvas.cpp',
+        '../third_party/skia/src/utils/debugger/SkDebugCanvas.h',
+        '../third_party/skia/src/utils/debugger/SkDrawCommand.cpp',
+        '../third_party/skia/src/utils/debugger/SkDrawCommand.h',
+        '../third_party/skia/src/utils/debugger/SkObjectParser.cpp',
+        '../third_party/skia/src/utils/debugger/SkObjectParser.h',
         '../third_party/skia/src/utils/mac/SkCreateCGImageRef.cpp',
         '../third_party/skia/src/utils/SkBase64.cpp',
         '../third_party/skia/src/utils/SkBase64.h',
         '../third_party/skia/src/utils/SkBitSet.cpp',
         '../third_party/skia/src/utils/SkBitSet.h',
         '../third_party/skia/src/utils/SkDeferredCanvas.cpp',
         '../third_party/skia/src/utils/SkMatrix44.cpp',
         '../third_party/skia/src/utils/SkNullCanvas.cpp',
         '../third_party/skia/include/utils/SkNWayCanvas.h',
         '../third_party/skia/src/utils/SkNWayCanvas.cpp',
@@ skipping 399 matching lines @@
           'xcode_settings': {
             'WARNING_CFLAGS!': [
               # Don't warn about string->bool used in asserts.
               '-Wstring-conversion',
             ],
           },
           'cflags!': [
             '-Wstring-conversion',
           ],
         }],
+        ['enable_graphics_context_annotations == 1', {
+          'defines': [
+            # Enable pretty-printing of certain Skia structures.
+            'SK_DEVELOPER',

[nduca, 2013/06/11 23:52:13]

what implications does this have?

[f(malita), 2013/06/12 13:32:37]

It mostly enables toString methods on some Skia types - for example, without it
getCommandInfo() doesn't show paint info. But there's something more going on in
SkPicturePlayback, I'll have to check with Mike what the intent is.

So the impact is hopefully just a small code size increase. Possibly enough
reason to keep this behind a compile flag?

+          ],
+        }],
       ],
       'dependencies': [
         'skia_opts',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         '../third_party/sfntly/sfntly.gyp:sfntly',
         '../third_party/zlib/zlib.gyp:zlib',
       ],
       'direct_dependent_settings': {
         'include_dirs': [
           'config',
@@ skipping 283 matching lines @@
           'sources': [
             '../third_party/skia/src/opts/SkBitmapProcState_opts_none.cpp',
             '../third_party/skia/src/opts/SkBlitRow_opts_none.cpp',
             '../third_party/skia/src/opts/SkUtils_opts_none.cpp',
           ],
         },
       ],
     }],
   ],
 }