Issue 15967002: [SPDY] Remove more code related to sending HEADERS frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15967002: [SPDY] Remove more code related to sending HEADERS frames (Closed)

Created:
7 years, 7 months ago by akalin

Modified:
7 years, 7 months ago

Reviewers:
Ryan Hamilton, akalin

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SPDY] Remove more code related to sending HEADERS frames Refactor out common code between SpdyStream::Do{SendBodyComplete,Open}(). Add comments and TODOs re. calls to SpdyStream::Delegate::OnResponseReceived() ending up deleting the stream. BUG=242288 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201986

Patch Set 1 #

Patch Set 2 : A few fixes #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -81 lines)			Patch
M	net/spdy/spdy_http_stream.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/spdy_http_stream.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/spdy/spdy_proxy_client_socket.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/spdy_proxy_client_socket.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/spdy/spdy_stream.h	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_stream.cc	View	1	7 chunks	+37 lines, -54 lines	0 comments	Download
M	net/spdy/spdy_stream_test_util.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_stream_test_util.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_websocket_stream.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/spdy_websocket_stream.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/15967002/4001

7 years, 7 months ago (2013-05-24 04:18:54 UTC) #3

akalin

7 years, 7 months ago (2013-05-24 06:42:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r201986 (presubmit successful).

Expand Messages | Collapse Messages