Issue 1596693002: simplify EmbedderUrlResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1596693002: simplify EmbedderUrlResolver (Closed)

Created:
4 years, 11 months ago by danrubel

Modified:
4 years, 11 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org, Cutch

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -109 lines)			Patch
	M	pkg/analyzer/lib/source/embedder.dart	View		5 chunks	+12 lines, -94 lines	0 comments	Download
	M	pkg/analyzer/test/source/embedder_test.dart	View	1	4 chunks	+31 lines, -15 lines	0 comments	Download

Total messages: 5 (2 generated)

danrubel

4 years, 11 months ago (2016-01-16 02:22:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1ef8fc8cec4cb8e77d6fb8da71c5fbb644651477 (presubmit successful).