Issue 159669: Change to WebMediaPlayerImpl incorrectly translated some pipeline errors....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159669: Change to WebMediaPlayerImpl incorrectly translated some pipeline errors.... (Closed)

Created:
11 years, 4 months ago by kylep

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com, fbarchard, kylep, awong, darin (slow to review), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change to WebMediaPlayerImpl incorrectly translated some pipeline errors. BUG=16738 TEST=run the media LayoutTests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22125

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	webkit/glue/webmediaplayer_impl.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kylep

That did the trick. The following should pass now: LayoutTests/media/unsupported-rtsp.html LayoutTests/media/video-error-does-not-exist.html LayoutTests/media/video-src-plus-source.html

11 years, 4 months ago (2009-07-30 23:25:06 UTC) #1

LGTM.

Expand Messages | Collapse Messages