ui/arc/notification/arc_notification_manager.h - Issue 1596663002: arc-bridge: Introduce the ArcService class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/arc/notification/arc_notification_manager.h

Issue 1596663002: arc-bridge: Introduce the ArcService class (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Rebased + protected ArcService direct instantiation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/arc/notification/arc_notification_manager.h

diff --git a/ui/arc/notification/arc_notification_manager.h b/ui/arc/notification/arc_notification_manager.h

index d197be81e4b643bea1ec9c52f12683b17fc85938..f463fa6f3e46efa769fa1aa712b02280b83f29cb 100644

--- a/ui/arc/notification/arc_notification_manager.h

+++ b/ui/arc/notification/arc_notification_manager.h

@@ -10,6 +10,7 @@

#include "base/containers/scoped_ptr_hash_map.h"

#include "components/arc/arc_bridge_service.h"

+#include "components/arc/arc_service.h"

#include "components/arc/common/notifications.mojom.h"

#include "components/signin/core/account_id/account_id.h"

#include "mojo/public/cpp/bindings/binding.h"

@@ -18,7 +19,8 @@ namespace arc {

class ArcNotificationItem;

-class ArcNotificationManager : public ArcBridgeService::Observer,

+class ArcNotificationManager : public ArcService,

+ public ArcBridgeService::Observer,

public NotificationsHost {

public:

ArcNotificationManager(ArcBridgeService* bridge_service,

@@ -37,7 +39,6 @@ class ArcNotificationManager : public ArcBridgeService::Observer,

void SendNotificationClickedOnChrome(const std::string& key);

private:

- ArcBridgeService* const arc_bridge_;

const AccountId main_profile_id_;

using ItemMap =