components/arc/ime/arc_ime_bridge.cc - Issue 1596663002: arc-bridge: Introduce the ArcService class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/ime/arc_ime_bridge.cc

Issue 1596663002: arc-bridge: Introduce the ArcService class (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Moved race avoidance boilerplate to ArcBridgeService Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/ime/arc_ime_bridge.cc

diff --git a/components/arc/ime/arc_ime_bridge.cc b/components/arc/ime/arc_ime_bridge.cc

index 1606f3f0c0f7a0226942fe2fb3fcc692f46b3f8c..c0205a7afe4528b749392adf7326dc60f1133470 100644

--- a/components/arc/ime/arc_ime_bridge.cc

+++ b/components/arc/ime/arc_ime_bridge.cc

@@ -30,8 +30,9 @@ bool IsArcWindow(const aura::Window* window) {

////////////////////////////////////////////////////////////////////////////////

// ArcImeBridge main implementation:

-ArcImeBridge::ArcImeBridge(ArcBridgeService* arc_bridge_service)

- : ipc_host_(this, arc_bridge_service),

+ArcImeBridge::ArcImeBridge(ArcBridgeService* bridge_service)

+ : ArcService(bridge_service),

+ ipc_host_(this, bridge_service),

ime_type_(ui::TEXT_INPUT_TYPE_NONE) {

aura::Env* env = aura::Env::GetInstanceDontCreate();

if (env)