Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: src/DartARM32/assembler_arm.cc

Issue 1596613002: Clean up handling of ARM IR instruction "mov". (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // This is forked from Dart revision df52deea9f25690eb8b66c5995da92b70f7ac1fe 5 // This is forked from Dart revision df52deea9f25690eb8b66c5995da92b70f7ac1fe
6 // Please update the (git) revision if we merge changes from Dart. 6 // Please update the (git) revision if we merge changes from Dart.
7 // https://code.google.com/p/dart/wiki/GettingTheSource 7 // https://code.google.com/p/dart/wiki/GettingTheSource
8 8
9 #include "vm/globals.h" // NOLINT 9 #include "vm/globals.h" // NOLINT
10 #if defined(TARGET_ARCH_ARM) 10 #if defined(TARGET_ARCH_ARM)
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 } 597 }
598 598
599 #if 0 599 #if 0
600 // Moved to ARM32::AssemblerARM32::nop(). 600 // Moved to ARM32::AssemblerARM32::nop().
601 void Assembler::nop(Condition cond) { 601 void Assembler::nop(Condition cond) {
602 ASSERT(cond != kNoCondition); 602 ASSERT(cond != kNoCondition);
603 int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) | 603 int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) |
604 B25 | B24 | B21 | (0xf << 12); 604 B25 | B24 | B21 | (0xf << 12);
605 Emit(encoding); 605 Emit(encoding);
606 } 606 }
607 #endif
608 607
609 608 // Moved to ARM32::AssemblerARM32::vmovsr().
610 void Assembler::vmovsr(SRegister sn, Register rt, Condition cond) { 609 void Assembler::vmovsr(SRegister sn, Register rt, Condition cond) {
611 ASSERT(TargetCPUFeatures::vfp_supported()); 610 ASSERT(TargetCPUFeatures::vfp_supported());
612 ASSERT(sn != kNoSRegister); 611 ASSERT(sn != kNoSRegister);
613 ASSERT(rt != kNoRegister); 612 ASSERT(rt != kNoRegister);
614 ASSERT(rt != SP); 613 ASSERT(rt != SP);
615 ASSERT(rt != PC); 614 ASSERT(rt != PC);
616 ASSERT(cond != kNoCondition); 615 ASSERT(cond != kNoCondition);
617 int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) | 616 int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) |
618 B27 | B26 | B25 | 617 B27 | B26 | B25 |
619 ((static_cast<int32_t>(sn) >> 1)*B16) | 618 ((static_cast<int32_t>(sn) >> 1)*B16) |
620 (static_cast<int32_t>(rt)*B12) | B11 | B9 | 619 (static_cast<int32_t>(rt)*B12) | B11 | B9 |
621 ((static_cast<int32_t>(sn) & 1)*B7) | B4; 620 ((static_cast<int32_t>(sn) & 1)*B7) | B4;
622 Emit(encoding); 621 Emit(encoding);
623 } 622 }
624 623 #endif
625 624
626 void Assembler::vmovrs(Register rt, SRegister sn, Condition cond) { 625 void Assembler::vmovrs(Register rt, SRegister sn, Condition cond) {
627 ASSERT(TargetCPUFeatures::vfp_supported()); 626 ASSERT(TargetCPUFeatures::vfp_supported());
628 ASSERT(sn != kNoSRegister); 627 ASSERT(sn != kNoSRegister);
629 ASSERT(rt != kNoRegister); 628 ASSERT(rt != kNoRegister);
630 ASSERT(rt != SP); 629 ASSERT(rt != SP);
631 ASSERT(rt != PC); 630 ASSERT(rt != PC);
632 ASSERT(cond != kNoCondition); 631 ASSERT(cond != kNoCondition);
633 int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) | 632 int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) |
634 B27 | B26 | B25 | B20 | 633 B27 | B26 | B25 | B20 |
(...skipping 3055 matching lines...) Expand 10 before | Expand all | Expand 10 after
3690 3689
3691 3690
3692 const char* Assembler::FpuRegisterName(FpuRegister reg) { 3691 const char* Assembler::FpuRegisterName(FpuRegister reg) {
3693 ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters)); 3692 ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters));
3694 return fpu_reg_names[reg]; 3693 return fpu_reg_names[reg];
3695 } 3694 }
3696 3695
3697 } // namespace dart 3696 } // namespace dart
3698 3697
3699 #endif // defined TARGET_ARCH_ARM 3698 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698