Improve container detection testing by adding additional containers

media/base/container_names.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/container_names.h"
 
 #include <cctype>
 #include <limits>
 
 #include "base/basictypes.h"
@@ skipping 213 matching lines @@
   // Verify video frames per second specified.
   RCHECK(Read32LE(buffer + 32) > 0);
 
   // Number of audio tracks must be 256 or less.
   return (Read32LE(buffer + 40) <= 256);
 }
 
 // Additional checks for a CAF container.
 static bool CheckCaf(const uint8* buffer, int buffer_size) {
   // Reference: Apple Core Audio Format Specification 1.0
-  // (http://goo.gl/Vgb9r)
+  // (https://developer.apple.com/library/mac/#documentation/MusicAudio/Reference/CAFSpec/CAF_spec/CAF_spec.html)
   RCHECK(buffer_size >= 52);
   BitReader reader(buffer, buffer_size);
 
   // mFileType should be "caff".
   RCHECK(ReadBits(&reader, 32) == TAG('c', 'a', 'f', 'f'));
 
   // mFileVersion should be 1.
   RCHECK(ReadBits(&reader, 16) == 1);
 
   // Skip mFileFlags.
@@ skipping 20 matching lines @@
 static bool kSamplingFrequencyValid[16] = { false, true, true, true, false,
                                             false, true, true, true, false,
                                             false, true, true, true, false,
                                             false };
 static bool kExtAudioIdValid[8] = { true, false, true, false, false, false,
                                     true, false };
 
 // Additional checks for a DTS container.
 static bool CheckDts(const uint8* buffer, int buffer_size) {
   // Reference: ETSI TS 102 114 V1.3.1 (2011-08)
-  // (http://goo.gl/FhHrk)
+  // (http://www.etsi.org/deliver/etsi_ts/102100_102199/102114/01.03.01_60/ts_102114v010301p.pdf)
   RCHECK(buffer_size > 11);
 
   int offset = 0;
   while (offset + 11 < buffer_size) {
     BitReader reader(buffer + offset, 11);
 
     // Verify sync word.
     RCHECK(ReadBits(&reader, 32) == 0x7ffe8001);
 
     // Skip frame type and deficit sample count.
@@ skipping 34 matching lines @@
     RCHECK(ReadBits(&reader, 2) != 3);
 
     offset += frame_size + 1;
   }
   return true;
 }
 
 // Checks for a DV container.
 static bool CheckDV(const uint8* buffer, int buffer_size) {
   // Reference: SMPTE 314M (Annex A has differences with IEC 61834).
-  // (http://goo.gl/kMn6p)
+  // (http://standards.smpte.org/content/978-1-61482-454-1/st-314-2005/SEC1.body.pdf)
   RCHECK(buffer_size > 11);
 
   int offset = 0;
   int current_sequence_number = -1;
   int last_block_number[6];
   while (offset + 11 < buffer_size) {
     BitReader reader(buffer + offset, 11);
 
     // Decode ID data. Sections 5, 6, and 7 are reserved.
     int section = ReadBits(&reader, 3);
@@ skipping 42 matching lines @@
     // Move to next block.
     offset += 80;
   }
   return true;
 }
 
 
 // Checks for a GSM container.
 static bool CheckGsm(const uint8* buffer, int buffer_size) {
   // Reference: ETSI EN 300 961 V8.1.1
-  // (http://goo.gl/h2VDS)
+  // (http://www.etsi.org/deliver/etsi_en/300900_300999/300961/08.01.01_60/en_300961v080101p.pdf)
   // also http://tools.ietf.org/html/rfc3551#page-24
   // GSM files have a 33 byte block, only first 4 bits are fixed.
   RCHECK(buffer_size >= 1024);  // Need enough data to do a decent check.
 
   int offset = 0;
   while (offset < buffer_size) {
     // First 4 bits of each block are xD.
     RCHECK((buffer[offset] & 0xf0) == 0xd0);
     offset += 33;
   }
@@ skipping 536 matching lines @@
         break;
     }
     // Skip this block.
     offset += 6;
   }
 }
 
 // Additional checks for a MOV/QuickTime/MPEG4 container.
 static bool CheckMov(const uint8* buffer, int buffer_size) {
   // Reference: ISO/IEC 14496-12:2005(E).
-  // (http://goo.gl/OWH0Q)
+  // (http://standards.iso.org/ittf/PubliclyAvailableStandards/c061988_ISO_IEC_14496-12_2012.zip)
   RCHECK(buffer_size > 8);
 
   int offset = 0;
   while (offset + 8 < buffer_size) {
     int atomsize = Read32(buffer + offset);
     uint32 atomtype = Read32(buffer + offset + 4);
     // Only need to check for ones that are valid at the top level.
     switch (atomtype) {
       case TAG('f','t','y','p'):
       case TAG('p','d','i','n'):
@@ skipping 330 matching lines @@
 
 enum VC1StartCodes {
   VC1_FRAME_START_CODE = 0x0d,
   VC1_ENTRY_POINT_START_CODE = 0x0e,
   VC1_SEQUENCE_START_CODE = 0x0f
 };
 
 // Checks for a VC1 bitstream container.
 static bool CheckVC1(const uint8* buffer, int buffer_size) {
   // Reference: SMPTE 421M
-  // (http://goo.gl/fLvaE)
+  // (http://standards.smpte.org/content/978-1-61482-555-5/st-421-2006/SEC1.body.pdf)
   // However, no length ... simply scan for start code values.
   // Expect to see SEQ | [ [ ENTRY ] PIC* ]*
   // Note tags are very similar to H.264.
 
   RCHECK(buffer_size >= 24);
 
   // First check for Bitstream Metadata Serialization (Annex L)
   if (buffer[0] == 0xc5 &&
       Read32(buffer + 4) == 0x04 &&
       Read32(buffer + 20) == 0x0c) {
@@ skipping 350 matching lines @@
     if (CheckEac3(buffer + offset, buffer_size - offset))
       return CONTAINER_EAC3;
   }
 
   return CONTAINER_UNKNOWN;
 }
 
 }  // namespace container_names
 
 }  // namespace media