Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 15966005: Improve container detection testing by adding additional containers (Closed)

Created:
7 years, 6 months ago by jrummell
Modified:
7 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve container detection testing by testing additional containers (new containers added https://codereview.chromium.org/16034004/). Also put back original reference URLs in source. BUG=235108 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203019

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -11 lines) Patch
M media/base/container_names.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M media/base/container_names_unittest.cc View 1 1 chunk +60 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jrummell
PTAL. Improve container detection testing by adding additional containers in the test directory (all generated ...
7 years, 6 months ago (2013-05-29 18:27:35 UTC) #1
xhwang
LGTM Could you please update the README about how you generated these files? (the command ...
7 years, 6 months ago (2013-05-29 18:41:50 UTC) #2
xhwang
https://codereview.chromium.org/15966005/diff/1/media/base/container_names_unittest.cc File media/base/container_names_unittest.cc (right): https://codereview.chromium.org/15966005/diff/1/media/base/container_names_unittest.cc#newcode114 media/base/container_names_unittest.cc:114: // Test several OGG files to ensure that the ...
7 years, 6 months ago (2013-05-29 18:43:22 UTC) #3
xhwang
Please also update the CL description with the correct BUG number. I found that the ...
7 years, 6 months ago (2013-05-29 18:46:29 UTC) #4
jrummell
New binary files have been checked in separately. This is now just updating the unit ...
7 years, 6 months ago (2013-05-29 20:46:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/15966005/5001
7 years, 6 months ago (2013-05-29 20:51:43 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 00:20:00 UTC) #7
Message was sent while issue was closed.
Change committed as 203019

Powered by Google App Engine
This is Rietveld 408576698