Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 15966004: cros: Move kiosk settings to extensions page. (Closed)

Created:
7 years, 7 months ago by xiyuan
Modified:
7 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, Aaron Boodman, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

cros: Move kiosk settings to extensions page. - Move kiosk settings to extensions page; - Remove the M28 temp flag; BUG=228860 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203327

Patch Set 1 #

Patch Set 2 : rebase and remove temp flag #

Total comments: 20

Patch Set 3 : for comments in #2 #

Total comments: 2

Patch Set 4 : fix space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -1209 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
A + chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js View 1 2 2 chunks +18 lines, -23 lines 0 comments Download
A + chrome/browser/resources/extensions/chromeos/kiosk_app_list.js View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/extensions/chromeos/kiosk_apps.css View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A + chrome/browser/resources/extensions/chromeos/kiosk_apps.html View 2 chunks +2 lines, -4 lines 0 comments Download
A + chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 1 2 2 chunks +28 lines, -37 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/options/chromeos/kiosk_app_disable_bailout_confirm.html View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/resources/options/chromeos/kiosk_app_disable_bailout_confirm.js View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/resources/options/chromeos/kiosk_app_list.js View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/resources/options/chromeos/kiosk_apps.css View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/resources/options/chromeos/kiosk_apps.html View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/resources/options/chromeos/kiosk_apps.js View 1 chunk +0 lines, -129 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 2 chunks +0 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js View 1 2 5 chunks +42 lines, -33 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h View 2 chunks +18 lines, -14 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 2 3 7 chunks +72 lines, -37 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 3 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/kiosk_apps_browsertest.js View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/kiosk_apps_handler.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/kiosk_apps_handler.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
7 years, 6 months ago (2013-05-30 17:46:15 UTC) #1
Dan Beam
generally lg https://codereview.chromium.org/15966004/diff/6001/chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js File chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js (right): https://codereview.chromium.org/15966004/diff/6001/chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js#newcode19 chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js:19: initializePage: function() { nit: I would maybe ...
7 years, 6 months ago (2013-05-30 21:14:54 UTC) #2
xiyuan
https://codereview.chromium.org/15966004/diff/6001/chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js File chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js (right): https://codereview.chromium.org/15966004/diff/6001/chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js#newcode19 chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js:19: initializePage: function() { On 2013/05/30 21:14:55, Dan Beam wrote: ...
7 years, 6 months ago (2013-05-30 23:03:37 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/15966004/diff/14001/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc File chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc (right): https://codereview.chromium.org/15966004/diff/14001/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc#newcode128 chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc:128: !base::chromeos::IsRunningOnChromeOS())); nit: -1 \s on L125-128
7 years, 6 months ago (2013-05-30 23:17:43 UTC) #4
xiyuan
https://codereview.chromium.org/15966004/diff/14001/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc File chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc (right): https://codereview.chromium.org/15966004/diff/14001/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc#newcode128 chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc:128: !base::chromeos::IsRunningOnChromeOS())); On 2013/05/30 23:17:43, Dan Beam wrote: > nit: ...
7 years, 6 months ago (2013-05-30 23:23:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/15966004/18002
7 years, 6 months ago (2013-05-30 23:24:12 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 03:47:39 UTC) #7
Message was sent while issue was closed.
Change committed as 203327

Powered by Google App Engine
This is Rietveld 408576698