Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 15966003: Revert 201806 "Create MetroViewerProcessHost as a common base fo..." (Closed)

Created:
7 years, 7 months ago by Dan Beam
Modified:
7 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 201806 "Create MetroViewerProcessHost as a common base fo..." Broke ash_unittests on Win8 Aura: http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/6316 [ RUN ] AcceleratorControllerTest.Register [912:1324:0523/094526:1371217:INFO:test_metro_viewer_process_host.cc(42)] ash::test::TestMetroViewerProcessHost::OnSetTargetSurface, target_surface = 131580 [912:1324:0523/094526:1371233:FATAL:ash_test_base.cc(149)] Check failed: !metro_viewer_host_->closed_unexpectedly(). Backtrace: base::debug::StackTrace::StackTrace [0x100839F1+33] logging::LogMessage::~LogMessage [0x100F6FCE+94] ash::test::AshTestBase::TearDown [0x006DC397+471] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x007405FF+319] testing::Test::Run [0x0072A525+229] testing::TestInfo::Run [0x0072AF4D+221] testing::TestCase::Run [0x0072B71F+239] testing::internal::UnitTestImpl::RunAllTests [0x0073234D+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00741227+327] testing::UnitTest::Run [0x00730BB0+192] base::TestSuite::Run [0x00756AE0+240] main [0x0058AFA4+100] __tmainCRTStartup [0x0075BA6F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x0075B89F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x76D78543+14] RtlInitializeExceptionChain [0x7775AC69+133] RtlInitializeExceptionChain [0x7775AC3C+88] (No symbol) [0x00000000] [912:1324:0523/094526:1371233:FATAL:ash_test_base.cc(149)] Check failed: !metro_viewer_host_->closed_unexpectedly(). Backtrace: base::debug::StackTrace::StackTrace [0x100839F1+33] logging::LogMessage::~LogMessage [0x100F6FCE+94] ash::test::AshTestBase::TearDown [0x006DC397+471] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x007405FF+319] testing::Test::Run [0x0072A525+229] testing::TestInfo::Run [0x0072AF4D+221] testing::TestCase::Run [0x0072B71F+239] testing::internal::UnitTestImpl::RunAllTests [0x0073234D+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00741227+327] testing::UnitTest::Run [0x00730BB0+192] base::TestSuite::Run [0x00756AE0+240] main [0x0058AFA4+100] __tmainCRTStartup [0x0075BA6F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x0075B89F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x76D78543+14] RtlInitializeExceptionChain [0x7775AC69+133] RtlInitializeExceptionChain [0x7775AC3C+88] (No symbol) [0x00000000] > Create MetroViewerProcessHost as a common base for TestMetroViewerProcessHost and ChromeMetroViewerProcessHost > > Bringing LaunchViewerAndWaitForConnection() to the common base so that ChromeMetroViewerProcessHost can also benefit from it (required for ash browser tests). > > BUG=179830 > > Review URL: https://chromiumcodereview.appspot.com/14629025 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -363 lines) Patch
M trunk/src/ash/ash.gyp View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/ash/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
MM trunk/src/ash/test/ash_test_base.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/ash/test/ash_test_base.cc View 1 chunk +1 line, -8 lines 0 comments Download
M trunk/src/ash/test/test_metro_viewer_process_host.h View 1 chunk +51 lines, -7 lines 0 comments Download
M trunk/src/ash/test/test_metro_viewer_process_host.cc View 1 chunk +71 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/browser_process_platform_part_aurawin.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/browser_process_platform_part_aurawin.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D trunk/src/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h View 1 chunk +0 lines, -24 lines 0 comments Download
D trunk/src/chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 chunk +0 lines, -86 lines 0 comments Download
A + trunk/src/chrome/browser/metro_viewer/metro_viewer_process_host_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/metro_viewer/metro_viewer_process_host_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/ui/aura/aura.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
MM trunk/src/ui/metro_viewer/metro_viewer.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/win8/metro_driver/metro_driver.gyp View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/win8/viewer/metro_viewer_process_host.h View 1 chunk +0 lines, -94 lines 0 comments Download
D trunk/src/win8/viewer/metro_viewer_process_host.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M trunk/src/win8/win8.gyp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
7 years, 7 months ago (2013-05-24 03:26:57 UTC) #1
Dan Beam
7 years, 7 months ago (2013-05-24 03:27:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r201966.

Powered by Google App Engine
This is Rietveld 408576698