DescriptionRevert 201806 "Create MetroViewerProcessHost as a common base fo..."
Broke ash_unittests on Win8 Aura:
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/6316
[ RUN ] AcceleratorControllerTest.Register
[912:1324:0523/094526:1371217:INFO:test_metro_viewer_process_host.cc(42)] ash::test::TestMetroViewerProcessHost::OnSetTargetSurface, target_surface = 131580
[912:1324:0523/094526:1371233:FATAL:ash_test_base.cc(149)] Check failed: !metro_viewer_host_->closed_unexpectedly().
Backtrace:
base::debug::StackTrace::StackTrace [0x100839F1+33]
logging::LogMessage::~LogMessage [0x100F6FCE+94]
ash::test::AshTestBase::TearDown [0x006DC397+471]
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x007405FF+319]
testing::Test::Run [0x0072A525+229]
testing::TestInfo::Run [0x0072AF4D+221]
testing::TestCase::Run [0x0072B71F+239]
testing::internal::UnitTestImpl::RunAllTests [0x0073234D+701]
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00741227+327]
testing::UnitTest::Run [0x00730BB0+192]
base::TestSuite::Run [0x00756AE0+240]
main [0x0058AFA4+100]
__tmainCRTStartup [0x0075BA6F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555)
mainCRTStartup [0x0075B89F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371)
BaseThreadInitThunk [0x76D78543+14]
RtlInitializeExceptionChain [0x7775AC69+133]
RtlInitializeExceptionChain [0x7775AC3C+88]
(No symbol) [0x00000000]
[912:1324:0523/094526:1371233:FATAL:ash_test_base.cc(149)] Check failed: !metro_viewer_host_->closed_unexpectedly().
Backtrace:
base::debug::StackTrace::StackTrace [0x100839F1+33]
logging::LogMessage::~LogMessage [0x100F6FCE+94]
ash::test::AshTestBase::TearDown [0x006DC397+471]
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x007405FF+319]
testing::Test::Run [0x0072A525+229]
testing::TestInfo::Run [0x0072AF4D+221]
testing::TestCase::Run [0x0072B71F+239]
testing::internal::UnitTestImpl::RunAllTests [0x0073234D+701]
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00741227+327]
testing::UnitTest::Run [0x00730BB0+192]
base::TestSuite::Run [0x00756AE0+240]
main [0x0058AFA4+100]
__tmainCRTStartup [0x0075BA6F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555)
mainCRTStartup [0x0075B89F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371)
BaseThreadInitThunk [0x76D78543+14]
RtlInitializeExceptionChain [0x7775AC69+133]
RtlInitializeExceptionChain [0x7775AC3C+88]
(No symbol) [0x00000000]
> Create MetroViewerProcessHost as a common base for TestMetroViewerProcessHost and ChromeMetroViewerProcessHost
>
> Bringing LaunchViewerAndWaitForConnection() to the common base so that ChromeMetroViewerProcessHost can also benefit from it (required for ash browser tests).
>
> BUG=179830
>
> Review URL: https://chromiumcodereview.appspot.com/14629025
TBR=gab@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201966
Patch Set 1 #Messages
Total messages: 2 (0 generated)
|