Issue 159658: Remove duplication of DieFileDie, and move it to proper location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159658: Remove duplication of DieFileDie, and move it to proper location. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Remove duplication of DieFileDie, and move it to proper location. TEST=none http://crbug.com/18085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22103

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -51 lines)			Patch
M	base/test_file_util.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	base/test_file_util_posix.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/test_file_util_win.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/download/save_page_uitest.cc	View	6 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/common/pref_service_uitest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/in_process_browser_test.cc	View	4 chunks	+6 lines, -21 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	2 chunks	+1 line, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

In case of concerns of bloating libbase, I filed http://crbug.com/18101 and I'm going to fix ...

11 years, 4 months ago (2009-07-30 20:57:50 UTC) #1

LGTM