Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: third_party/WebKit/Source/web/tests/sim/SimWebViewClient.cpp

Issue 1596573002: Remove extra calls of didMeaningfulLayout() during the same navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/sim/SimWebViewClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/sim/SimWebViewClient.cpp
diff --git a/third_party/WebKit/Source/web/tests/sim/SimWebViewClient.cpp b/third_party/WebKit/Source/web/tests/sim/SimWebViewClient.cpp
index 46d84102467b3d83930d2a19815abfa72a8d26b7..fb62d4f3911e3fb5c2e3721839071d86f1ed34cd 100644
--- a/third_party/WebKit/Source/web/tests/sim/SimWebViewClient.cpp
+++ b/third_party/WebKit/Source/web/tests/sim/SimWebViewClient.cpp
@@ -9,9 +9,9 @@
namespace blink {
SimWebViewClient::SimWebViewClient(WebLayerTreeView& layerTreeView)
- : m_hadVisuallyNonEmptyLayout(false)
- , m_hadFinishedParsingLayout(false)
- , m_hadFinishedLoadingLayout(false)
+ : m_visuallyNonEmptyLayoutCount(0)
+ , m_finishedParsingLayoutCount(0)
+ , m_finishedLoadingLayoutCount(0)
, m_layerTreeView(&layerTreeView)
{
}
@@ -20,13 +20,13 @@ void SimWebViewClient::didMeaningfulLayout(WebMeaningfulLayout meaningfulLayout)
{
switch (meaningfulLayout) {
case WebMeaningfulLayout::VisuallyNonEmpty:
- m_hadVisuallyNonEmptyLayout = true;
+ m_visuallyNonEmptyLayoutCount++;
break;
case WebMeaningfulLayout::FinishedParsing:
- m_hadFinishedParsingLayout = true;
+ m_finishedParsingLayoutCount++;
break;
case WebMeaningfulLayout::FinishedLoading:
- m_hadFinishedLoadingLayout = true;
+ m_finishedLoadingLayoutCount++;
break;
}
}
« no previous file with comments | « third_party/WebKit/Source/web/tests/sim/SimWebViewClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698