Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1596573002: Remove extra calls of didMeaningfulLayout() during the same navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 // based on the Webkit function bool WebView::handleContextMenuEvent(WPARAM 365 // based on the Webkit function bool WebView::handleContextMenuEvent(WPARAM
366 // wParam, LPARAM lParam) in webkit\webkit\win\WebView.cpp. The only 366 // wParam, LPARAM lParam) in webkit\webkit\win\WebView.cpp. The only
367 // significant change in this function is the code to convert from a 367 // significant change in this function is the code to convert from a
368 // Keyboard event to the Right Mouse button down event. 368 // Keyboard event to the Right Mouse button down event.
369 WebInputEventResult sendContextMenuEvent(const WebKeyboardEvent&); 369 WebInputEventResult sendContextMenuEvent(const WebKeyboardEvent&);
370 370
371 void showContextMenuAtPoint(float x, float y, PassRefPtrWillBeRawPtr<Context MenuProvider>); 371 void showContextMenuAtPoint(float x, float y, PassRefPtrWillBeRawPtr<Context MenuProvider>);
372 372
373 void showContextMenuForElement(WebElement); 373 void showContextMenuForElement(WebElement);
374 374
375 // Notifies the WebView that a load has been committed. isNewNavigation 375 // Notifies the WebView that a load has been committed.
376 // will be true if a new session history item should be created for that 376 // isNavigationWithinPage will be true if the navigation does
377 // load. isNavigationWithinPage will be true if the navigation does
378 // not take the user away from the current page. 377 // not take the user away from the current page.
379 void didCommitLoad(bool isNewNavigation, bool isNavigationWithinPage); 378 void didCommitLoad(HistoryCommitType, bool isNavigationWithinPage);
380 379
381 void postLayoutResize(WebLocalFrameImpl* webframe); 380 void postLayoutResize(WebLocalFrameImpl* webframe);
382 381
383 // Indicates two things: 382 // Indicates two things:
384 // 1) This view may have a new layout now. 383 // 1) This view may have a new layout now.
385 // 2) Calling updateAllLifecyclePhases() is a no-op. 384 // 2) Calling updateAllLifecyclePhases() is a no-op.
386 // After calling WebWidget::updateAllLifecyclePhases(), expect to get this n otification 385 // After calling WebWidget::updateAllLifecyclePhases(), expect to get this n otification
387 // unless the view did not need a layout. 386 // unless the view did not need a layout.
388 void layoutUpdated(WebLocalFrameImpl*); 387 void layoutUpdated(WebLocalFrameImpl*);
389 388
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
775 }; 774 };
776 775
777 DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.is WebView()); 776 DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.is WebView());
778 // We have no ways to check if the specified WebView is an instance of 777 // We have no ways to check if the specified WebView is an instance of
779 // WebViewImpl because WebViewImpl is the only implementation of WebView. 778 // WebViewImpl because WebViewImpl is the only implementation of WebView.
780 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 779 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
781 780
782 } // namespace blink 781 } // namespace blink
783 782
784 #endif 783 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698