Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 159653005: Not for committing. Proof that NaCl stuff is insane.

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Not for committing. Proof that NaCl stuff is insane. Test breakage: http://build.chromium.org/p/client.v8/builders/NaCl%20V8%20Linux64%20-%20stable/builds/1587/steps/Check/logs/stdio With these debug prints, the test will print out: ReportInvalidPreparseData constructed args array, length is 1 ParserBase::ReportMessage invalid_preparser_data, args len 30643 ParserTraits::ReportMessageAt message invalid_preparser_data, args len 30643 looping 0 bar looping 1 (null) and crash. Note that v8::internal::Vector has an implicit copy ctor which does the right thing, and that they are passed as params all over v8.

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : oops #

Patch Set 4 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M src/parser.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M src/preparser.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/preparser.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +27 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698