Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 159653004: SkBitmap now really stores SkImageInfo -- config is just a ruse (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SkBitmap now really stores SkImageInfo -- config is just a ruse BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13411

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -258 lines) Patch
M include/core/SkBitmap.h View 8 chunks +62 lines, -52 lines 0 comments Download
M include/core/SkImageInfo.h View 6 chunks +42 lines, -4 lines 0 comments Download
M include/core/SkPathRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 31 chunks +126 lines, -163 lines 0 comments Download
M src/image/SkImagePriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImagePriv.cpp View 1 chunk +11 lines, -27 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tests/PixelRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
This is the same as the previously named CL, but with warning fixes. ptal
6 years, 10 months ago (2014-02-11 16:33:04 UTC) #1
scroggo
On 2014/02/11 16:33:04, reed1 wrote: > This is the same as the previously named CL, ...
6 years, 10 months ago (2014-02-11 16:42:25 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-11 16:49:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/159653004/1
6 years, 10 months ago (2014-02-11 16:49:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 16:49:49 UTC) #5
commit-bot: I haz the power
Failed to apply patch for src/gpu/GrClipMaskManager.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-11 16:49:49 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-11 17:04:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/159653004/120001
6 years, 10 months ago (2014-02-11 17:05:03 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 18:21:53 UTC) #9
Message was sent while issue was closed.
Change committed as 13411

Powered by Google App Engine
This is Rietveld 408576698