Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 159653003: Get rid of the function sorting in for polymorphic calls. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Get rid of the function sorting in for polymorphic calls. The idea of this code was to sort functions according to ticks spend executing them, but now these ticks are always zero and therefore we fall back to sorting by AST length (or even worse by source length) all the time, which is a bad, arbitrary measure. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19267

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplified patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M src/hydrogen.cc View 1 2 chunks +3 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
PTAL
6 years, 10 months ago (2014-02-11 10:22:27 UTC) #1
Toon Verwaest
https://codereview.chromium.org/159653003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/159653003/diff/1/src/hydrogen.cc#newcode6785 src/hydrogen.cc:6785: for (int i = 0; i < types->length(); ++i) ...
6 years, 10 months ago (2014-02-11 10:32:48 UTC) #2
Benedikt Meurer
Simplified, fixed patch. https://codereview.chromium.org/159653003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/159653003/diff/1/src/hydrogen.cc#newcode6785 src/hydrogen.cc:6785: for (int i = 0; i ...
6 years, 10 months ago (2014-02-11 10:34:54 UTC) #3
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-11 10:46:04 UTC) #4
Benedikt Meurer
6 years, 10 months ago (2014-02-11 10:48:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698