Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 159653002: Fix gcstress test failure (Closed)

Created:
6 years, 10 months ago by mvstanton
Modified:
6 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Fix gcstress test failure Map collection complicates a test that wants to assert on code opt/deopt because of prototype-chain changes. It can happen that a gc occurs in the stack guard at the start of optimized function foo that deopts function foo because of a map being collected and deoptimizing it's dependent code. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M test/mjsunit/getters-on-elements.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Benedikt, PTAL, thx! --Michael
6 years, 10 months ago (2014-02-11 08:57:36 UTC) #1
Benedikt Meurer
LGTM, nice debugging! :-)
6 years, 10 months ago (2014-02-11 09:00:14 UTC) #2
mvstanton
6 years, 10 months ago (2014-02-11 09:06:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698