Issue 15965004: [Android] Simplify the month and time picker removing unused functionality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15965004: [Android] Simplify the month and time picker removing unused functionality (Closed)

Created:
7 years, 7 months ago by Miguel Garcia

Modified:
7 years, 7 months ago

Reviewers:
Miguel Garcia, bulach, commit-bot: I haz the power

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Simplify the month and time picker removing unused functionality BUG=135948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202135

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -207 lines)			Patch
M	content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java	View	3 chunks	+2 lines, -48 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/input/MonthPicker.java	View	8 chunks	+1 line, -108 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/input/MonthPickerDialog.java	View	2 chunks	+1 line, -51 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Miguel Garcia

As agreed on the min/max review here is part I of the simplification of the ...

7 years, 7 months ago (2013-05-24 13:45:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/15965004/1

7 years, 7 months ago (2013-05-24 14:35:06 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118060

7 years, 7 months ago (2013-05-24 16:07:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/15965004/1

7 years, 7 months ago (2013-05-24 16:20:30 UTC) #5

Message was sent while issue was closed.

Change committed as 202135

Expand Messages | Collapse Messages