Chromium Code Reviews| Index: test/cctest/test-debug.cc |
| diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc |
| index c4df73ebbd201ab90ea6a4e363457afd3ac2c753..8ec6a7cb626ef4cc0a96541e6550771c49f7ae2d 100644 |
| --- a/test/cctest/test-debug.cc |
| +++ b/test/cctest/test-debug.cc |
| @@ -29,10 +29,6 @@ |
| #include <stdlib.h> |
| -// TODO(dcarney): remove |
| -#define V8_ALLOW_ACCESS_TO_PERSISTENT_ARROW |
| -#define V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT |
| - |
| #include "v8.h" |
| #include "api.h" |
| @@ -6624,9 +6620,10 @@ TEST(ScriptCollectedEventContext) { |
| v8::Persistent<v8::Context> context; |
| { |
| v8::HandleScope scope(isolate); |
| - context.Reset(isolate, v8::Context::New(isolate)); |
| + v8::Local<v8::Context> local_context = v8::Context::New(isolate); |
|
Sven Panne
2013/05/28 11:06:52
Can't we use Context::Scope here? BTW: It would be
|
| + context.Reset(isolate, local_context); |
| + local_context->Enter(); |
| } |
| - context->Enter(); |
| // Request the loaded scripts to initialize the debugger script cache. |
| debug->GetLoadedScripts(); |
| @@ -6639,7 +6636,12 @@ TEST(ScriptCollectedEventContext) { |
| v8::Script::Compile(v8::String::New("eval('a=1')"))->Run(); |
| v8::Script::Compile(v8::String::New("eval('a=2')"))->Run(); |
| - context->Exit(); |
| + { |
| + v8::HandleScope scope(isolate); |
| + v8::Local<v8::Context> local_context = |
| + v8::Local<v8::Context>::New(isolate, context); |
| + local_context->Exit(); |
| + } |
| context.Dispose(isolate); |
| // Do garbage collection to collect the script above which is no longer |