Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 15964004: remove most V8_ALLOW_ACCESS_TO_* defines from test classes (Closed)

Created:
7 years, 6 months ago by dcarney
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove most V8_ALLOW_ACCESS_TO_* defines from test classes R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14849

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -194 lines) Patch
M include/v8.h View 2 chunks +17 lines, -0 lines 0 comments Download
M test/cctest/cctest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 3 chunks +16 lines, -6 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 2 chunks +1 line, -5 lines 0 comments Download
M test/cctest/test-decls.cc View 3 chunks +12 lines, -14 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-hashing.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 9 chunks +41 lines, -37 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 5 chunks +11 lines, -19 lines 0 comments Download
M test/cctest/test-lockers.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-log.cc View 5 chunks +6 lines, -15 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-random.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 6 chunks +23 lines, -15 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 6 months ago (2013-05-28 10:33:11 UTC) #1
Sven Panne
LGTM with a nit https://codereview.chromium.org/15964004/diff/1/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/15964004/diff/1/test/cctest/test-debug.cc#newcode6623 test/cctest/test-debug.cc:6623: v8::Local<v8::Context> local_context = v8::Context::New(isolate); Can't ...
7 years, 6 months ago (2013-05-28 11:06:51 UTC) #2
dcarney
7 years, 6 months ago (2013-05-28 11:55:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698