Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: src/heap/spaces.h

Issue 1596343004: [heap] Sort sweep pages list by free memory. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed compilation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact-inl.h ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index 532c9b2e878f2cad7e1a3dc3d2c67ae6443d5490..f14b17b74baa97f0c4ffc4ac554a3ce017404ac6 100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -2116,10 +2116,6 @@ class PagedSpace : public Space {
// It returns true when sweeping is completed and false otherwise.
bool EnsureSweeperProgress(intptr_t size_in_bytes);
- void set_end_of_unswept_pages(Page* page) { end_of_unswept_pages_ = page; }
-
- Page* end_of_unswept_pages() { return end_of_unswept_pages_; }
-
Page* FirstPage() { return anchor_.next_page(); }
Page* LastPage() { return anchor_.prev_page(); }
@@ -2147,6 +2143,8 @@ class PagedSpace : public Space {
virtual void RefillFreeList();
protected:
+ static const int kMaxPagesSweptDuringSlowAllocation = 1;
Hannes Payer (out of office) 2016/01/21 10:35:22 This one can be local in the function.
+
void AddMemory(Address start, intptr_t size);
FreeSpace* TryRemoveMemory(intptr_t size_in_bytes);
@@ -2203,11 +2201,6 @@ class PagedSpace : public Space {
// Normal allocation information.
AllocationInfo allocation_info_;
- // The sweeper threads iterate over the list of pointer and data space pages
- // and sweep these pages concurrently. They will stop sweeping after the
- // end_of_unswept_pages_ page.
- Page* end_of_unswept_pages_;
-
// Mutex guarding any concurrent access to the space.
base::Mutex space_mutex_;
« no previous file with comments | « src/heap/mark-compact-inl.h ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698