Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: tools/test.dart

Issue 15963011: Use run_vm_tests.host to list VM tests if possible (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/cross-vm.py ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 781ae2cac3c38ffc60ed165c5fb01b47c0f486ed..b1c587a55d7c7b5ca272d5f673b34d539dde174f 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -167,16 +167,9 @@ void testConfigurations(List<Map> configurations) {
if (key == 'co19') {
testSuites.add(new Co19TestSuite(conf));
} else if (conf['runtime'] == 'vm' && key == 'vm') {
- // TODO(kustermann): Currently we don't support running VM unittest
- // tests (i.e. run_vm_tests) on ARM because:
- // a) we currently use record&replay [test.dart cannot be used on ARM]
- // b) we cannot easily determine all the VM test names
- // [we would need to run 'run_vm_tests --list' on ARM]
- if (!['arm', 'mips'].contains(conf['arch'])) {
- // vm tests contain both cc tests (added here) and dart tests (added
- // in [TEST_SUITE_DIRECTORIES]).
- testSuites.add(new VMTestSuite(conf));
- }
+ // vm tests contain both cc tests (added here) and dart tests (added
+ // in [TEST_SUITE_DIRECTORIES]).
+ testSuites.add(new VMTestSuite(conf));
} else if (conf['analyzer']) {
if (key == 'dartc' && conf['compiler'] == 'dartc') {
testSuites.add(new JUnitDartcTestSuite(conf));
« no previous file with comments | « tools/bots/cross-vm.py ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698