Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/mips/macro-assembler-mips.cc

Issue 1596293003: Use default argument count for runtime function calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/mips64/macro-assembler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright 2012 the V8 project authors. All rights reserved. 2 // Copyright 2012 the V8 project authors. All rights reserved.
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 #include <limits.h> // For LONG_MIN, LONG_MAX. 6 #include <limits.h> // For LONG_MIN, LONG_MAX.
7 7
8 #if V8_TARGET_ARCH_MIPS 8 #if V8_TARGET_ARCH_MIPS
9 9
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 4041 matching lines...) Expand 10 before | Expand all | Expand 10 after
4052 } 4052 }
4053 if (actual.is_reg()) { 4053 if (actual.is_reg()) {
4054 SmiTag(actual.reg()); 4054 SmiTag(actual.reg());
4055 Push(actual.reg()); 4055 Push(actual.reg());
4056 } 4056 }
4057 if (new_target.is_valid()) { 4057 if (new_target.is_valid()) {
4058 Push(new_target); 4058 Push(new_target);
4059 } 4059 }
4060 Push(fun); 4060 Push(fun);
4061 Push(fun); 4061 Push(fun);
4062 CallRuntime(Runtime::kDebugPrepareStepInIfStepping, 1); 4062 CallRuntime(Runtime::kDebugPrepareStepInIfStepping);
4063 Pop(fun); 4063 Pop(fun);
4064 if (new_target.is_valid()) { 4064 if (new_target.is_valid()) {
4065 Pop(new_target); 4065 Pop(new_target);
4066 } 4066 }
4067 if (actual.is_reg()) { 4067 if (actual.is_reg()) {
4068 Pop(actual.reg()); 4068 Pop(actual.reg());
4069 SmiUntag(actual.reg()); 4069 SmiUntag(actual.reg());
4070 } 4070 }
4071 if (expected.is_reg()) { 4071 if (expected.is_reg()) {
4072 Pop(expected.reg()); 4072 Pop(expected.reg());
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
4680 } 4680 }
4681 #endif 4681 #endif
4682 4682
4683 li(a0, Operand(Smi::FromInt(reason))); 4683 li(a0, Operand(Smi::FromInt(reason)));
4684 push(a0); 4684 push(a0);
4685 // Disable stub call restrictions to always allow calls to abort. 4685 // Disable stub call restrictions to always allow calls to abort.
4686 if (!has_frame_) { 4686 if (!has_frame_) {
4687 // We don't actually want to generate a pile of code for this, so just 4687 // We don't actually want to generate a pile of code for this, so just
4688 // claim there is a stack frame, without generating one. 4688 // claim there is a stack frame, without generating one.
4689 FrameScope scope(this, StackFrame::NONE); 4689 FrameScope scope(this, StackFrame::NONE);
4690 CallRuntime(Runtime::kAbort, 1); 4690 CallRuntime(Runtime::kAbort);
4691 } else { 4691 } else {
4692 CallRuntime(Runtime::kAbort, 1); 4692 CallRuntime(Runtime::kAbort);
4693 } 4693 }
4694 // Will not return here. 4694 // Will not return here.
4695 if (is_trampoline_pool_blocked()) { 4695 if (is_trampoline_pool_blocked()) {
4696 // If the calling code cares about the exact number of 4696 // If the calling code cares about the exact number of
4697 // instructions generated, we insert padding here to keep the size 4697 // instructions generated, we insert padding here to keep the size
4698 // of the Abort macro constant. 4698 // of the Abort macro constant.
4699 // Currently in debug mode with debug_code enabled the number of 4699 // Currently in debug mode with debug_code enabled the number of
4700 // generated instructions is 10, so we use this as a maximum value. 4700 // generated instructions is 10, so we use this as a maximum value.
4701 static const int kExpectedAbortInstructions = 10; 4701 static const int kExpectedAbortInstructions = 10;
4702 int abort_instructions = InstructionsGeneratedSince(&abort_start); 4702 int abort_instructions = InstructionsGeneratedSince(&abort_start);
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
5788 if (mag.shift > 0) sra(result, result, mag.shift); 5788 if (mag.shift > 0) sra(result, result, mag.shift);
5789 srl(at, dividend, 31); 5789 srl(at, dividend, 31);
5790 Addu(result, result, Operand(at)); 5790 Addu(result, result, Operand(at));
5791 } 5791 }
5792 5792
5793 5793
5794 } // namespace internal 5794 } // namespace internal
5795 } // namespace v8 5795 } // namespace v8
5796 5796
5797 #endif // V8_TARGET_ARCH_MIPS 5797 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/mips64/macro-assembler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698