chrome/browser/resources/history/externs.js - Issue 1596273003: [Android] Use fallback icon if there is no large favicon on the history page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/externs.js

Issue 1596273003: [Android] Use fallback icon if there is no large favicon on the history page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/history/externs.js

diff --git a/chrome/browser/resources/history/externs.js b/chrome/browser/resources/history/externs.js

index fe44653904ef63a57263d486d5bd77f1f2b2a7ad..30dcf49d9548ca578cb4886ff266bc023157c97b 100644

--- a/chrome/browser/resources/history/externs.js

+++ b/chrome/browser/resources/history/externs.js

@@ -19,6 +19,7 @@

* deviceName: string,

* deviceType: string,

* domain: string,

+ * fallbackFaviconChar: string,

Dan Beam 2016/02/06 03:34:29 i don't think this is right, you should run the cl

pkotwicz 2016/02/06 04:31:27 Thanks for catching!

* hostFilteringBehavior: number,

* snippet: string,

* starred: boolean,

« no previous file with comments | « no previous file | chrome/browser/resources/history/history.css » ('j') | chrome/browser/resources/history/history_mobile.css » ('J')