Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5455)

Unified Diff: chrome/browser/resources/history/history.css

Issue 1596273003: [Android] Use fallback icon if there is no large favicon on the history page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/history/history.css
diff --git a/chrome/browser/resources/history/history.css b/chrome/browser/resources/history/history.css
index f3d432b3f6d10137b2d1e3d1c92c3da0724d037b..e455dc5f954d7de98cc6bb1f2c9cff8618b63ae0 100644
--- a/chrome/browser/resources/history/history.css
+++ b/chrome/browser/resources/history/history.css
@@ -335,10 +335,6 @@ html[dir='rtl'] .number-visits {
}
html[dir='rtl'] .entry .title,
-html[dir='rtl'] .site-domain {
- /* Put the favicon on the right. */
- background-position-x: right;
-}
.entry .time {
color: rgb(151, 156, 160);
@@ -447,38 +443,29 @@ html[dir='rtl'] .site-domain {
white-space: nowrap;
}
-.entry .visit-entry,
-.site-domain {
- /* Make room for the favicon. */
- -webkit-padding-start: 16px;
-}
-
-.entry .visit-entry,
-.site-domain,
-.blocked-indicator {
- /* Control the favicon appearance. */
- background-position-y: center;
- background-repeat: no-repeat;
- background-size: 16px;
-}
-
-html[dir='rtl'] .entry .visit-entry,
-html[dir='rtl'] .site-domain,
-html[dir='rtl'] .blocked-indicator {
- background-position-x: right;
-}
Dan Beam 2016/02/05 20:42:11 how can you nuke all this without breaking somethi
pkotwicz 2016/02/06 02:59:55 The rtl background-position-x CSS switches the pos
-
/* TODO(sergiu): If this is the final icon replace it with a separate resource.
*/
.entry .blocked-indicator {
- -webkit-padding-start: 20px; /* 16px for favicon, 4px for <a> padding. */
- background-image: url(../ssl/images/roadblock.png);
+ -webkit-padding-start: 4px; /* For <a> padding. */
}
.blocked-indicator .title {
color: rgb(151, 156, 160);
}
+.blocked-icon {
+ background-image: url(../ssl/images/roadblock.png)
+}
+
+.favicon {
+ background-position-y: center;
+ background-repeat: no-repeat;
+ background-size: 16px;
+ flex-shrink: 0;
+ height: 16px;
+ width: 16px;
+}
+
.site-domain button:hover {
text-decoration: none;
}
« no previous file with comments | « no previous file | chrome/browser/resources/history/history.js » ('j') | chrome/browser/resources/history/history.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698