Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 159623: Implement the download arrow animation for Mac (Closed)

Created:
11 years, 4 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

Implement the download arrow animation for Mac. TEST=Download something and notice the nice download arrow animation. BUG=14661 (http://crbug.com/14661) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22355

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -3 lines) Patch
M chrome/browser/browser.cc View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
A chrome/browser/cocoa/download_started_animation_mac.mm View 1 2 1 chunk +200 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Godavari
11 years, 4 months ago (2009-07-30 03:14:31 UTC) #1
Avi (use Gerrit)
Looks pretty slick! LG http://codereview.chromium.org/159623/diff/1/3 File chrome/browser/cocoa/download_started_animation_mac.mm (right): http://codereview.chromium.org/159623/diff/1/3#newcode22 Line 22: CGImageRef image_; scoped_cftyperef?
11 years, 4 months ago (2009-07-30 13:46:09 UTC) #2
Paul Godavari
- Updated to fix a crash in ui_tests. - Added a watcher object to cancel ...
11 years, 4 months ago (2009-07-31 22:24:39 UTC) #3
Avi (use Gerrit)
11 years, 4 months ago (2009-08-03 21:28:18 UTC) #4
Still LG.

Powered by Google App Engine
This is Rietveld 408576698