Revert 202185 "Fix AutofillDialogCocoaBrowserTest.DisplayUI."

Revert 202185 "Fix AutofillDialogCocoaBrowserTest.DisplayUI."

> Fix AutofillDialogCocoaBrowserTest.DisplayUI.
>
> This re-lands a fixed version of r196005, which was reverted.
>
> BUG=234008
> TEST=AutofillDialogCocoaBrowserTest.DisplayUI works everywhere
>
> Review URL: https://chromiumcodereview.appspot.com/16025002

TBR=avi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202343

[xiyuan, 2013-05-26 03:45:06]

Fails on MacASan.

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%28...

[ RUN      ] AutofillDialogCocoaBrowserTest.DisplayUI
...
=================================================================
==4591==ERROR: AddressSanitizer: heap-use-after-free on address 0x4550dbc4 at pc
0x1c4958c bp 0xbff10478 sp 0xbff10474
READ of size 4 at 0x4550dbc4 thread T0
    #0 0x1c4958b in non-virtual thunk to autofill::(anonymous
namespace)::TestAutofillDialogControdyld: warning, unknown environment variable:
DYLD_NO_PIE
dyld: warning, unknown environment variable: DYLD_NO_PIE
ller::~TestAutofillDialogController() (in browser_tests) + 267
    #1 0x4259ccd in -[AutofillDialogWindowController
initWithWebContents:autofillDialog:] (in browser_tests) + 4029
    #2 0x430dfb3 in +[ConstrainedWindowSheetController sheetForOverlayWindow:]
(in browser_tests) + 1443
    #3 0x42597f0 in -[AutofillDialogWindowController
initWithWebContents:autofillDialog:] (in browser_tests) + 2784
    #4 0x419b70d in
autofill::AutofillDialogControllerImpl::EnsureLegalDocumentsText() (in
browser_tests) + 909
    #5 0x1c4928c in non-virtual thunk to autofill::(anonymous
namespace)::TestAutofillDialogController::~TestAutofillDialogController() (in
browser_tests) + 28
    #6 0xd77e9ae in TestMessageHandler::~TestMessageHandler() (in browser_tests)
+ 142
    #7 0x60f9bfe in content::SimulateMouseClick(content::WebContents*, int,
WebKit::WebMouseEvent::Button) (in browser_tests) + 574
    #8 0x60fa288 in content::SimulateMouseClick(content::WebContents*, int,
WebKit::WebMouseEvent::Button) (in browser_tests) + 2248
    #9 0x90b4d50 in ChromeBrowserMainParts::PreProfileInit() (in browser_tests)
+ 1040
    #10 0x90b0015 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() (in
browser_tests) + 3205
    #11 0x86fba45 in content::BrowserMainLoop::BrowserThreadsStarted() (in
browser_tests) + 2261
    #12 0x8700bed in non-virtual thunk to
content::BrowserPluginEmbedder::~BrowserPluginEmbedder() (in browser_tests) + 29
    #13 0x86f62fd in content::BrowserMainLoop::~BrowserMainLoop() (in
browser_tests) + 2717
    #14 0x60f995d in content::CrashTab(content::WebContents*) (in browser_tests)
+ 397
    #15 0xd77b21a in InProcessBrowserTest::SetUp() (in browser_tests) + 6170
    #16 0x5081401 in std::string testing::internal::StreamableToString<long
long>(long long const&) (in browser_tests) + 897
    #17 0x5063c61 in testing::TestInfo::~TestInfo() (in browser_tests) + 897
    #18 0x5065e16 in testing::TestCase::Run() (in browser_tests) + 1702
...
0x4550dbc4 is located 1092 bytes inside of 1096-byte region
[0x4550d780,0x4550dbc8)
freed by thread T0 here:
    #0 0x14df3467 in wrap__ZdlPv (in libclang_rt.asan_osx_dynamic.dylib) + 23
    #1 0x1c4950f in non-virtual thunk to autofill::(anonymous
namespace)::TestAutofillDialogController::~TestAutofillDialogController() (in
browser_tests) + 143
    #2 0x4259ccd in -[AutofillDialogWindowController
initWithWebContents:autofillDialog:] (in browser_tests) + 4029
    #3 0x430dfb3 in +[ConstrainedWindowSheetController sheetForOverlayWindow:]
(in browser_tests) + 1443
    #4 0x42597f0 in -[AutofillDialogWindowController
initWithWebContents:autofillDialog:] (in browser_tests) + 2784
    #5 0x419b70d in
autofill::AutofillDialogControllerImpl::EnsureLegalDocumentsText() (in
browser_tests) + 909
    #6 0x1c4928c in non-virtual thunk to autofill::(anonymous
namespace)::TestAutofillDialogController::~TestAutofillDialogController() (in
browser_tests) + 28
    #7 0xd77e9ae in TestMessageHandler::~TestMessageHandler() (in browser_tests)
+ 142
    #8 0x60f9bfe in content::SimulateMouseClick(content::WebContents*, int,
WebKit::WebMouseEvent::Button) (in browser_tests) + 574
    #9 0x60fa288 in content::SimulateMouseClick(content::WebContents*, int,
WebKit::WebMouseEvent::Button) (in browser_tests) + 2248
    #10 0x90b4d50 in ChromeBrowserMainParts::PreProfileInit() (in browser_tests)
+ 1040
    #11 0x90b0015 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() (in
browser_tests) + 3205
    #12 0x86fba45 in content::BrowserMainLoop::BrowserThreadsStarted() (in
browser_tests) + 2261
    #13 0x8700bed in non-virtual thunk to
content::BrowserPluginEmbedder::~BrowserPluginEmbedder() (in browser_tests) + 29
    #14 0x86f62fd in content::BrowserMainLoop::~BrowserMainLoop() (in
browser_tests) + 2717
    #15 0x60f995d in content::CrashTab(content::WebContents*) (in browser_tests)
+ 397
    #16 0xd77b21a in InProcessBrowserTest::SetUp() (in browser_tests) + 6170
    #17 0x5081401 in std::string testing::internal::StreamableToString<long
long>(long long const&) (in browser_tests) + 897
    #18 0x5063c61 in testing::TestInfo::~TestInfo() (in browser_tests) + 897
    #19 0x5065e16 in testing::TestCase::Run() (in browser_tests) + 1702
...
previously allocated by thread T0 here:
    #0 0x14df32a7 in wrap__Znwm (in libclang_rt.asan_osx_dynamic.dylib) + 23
    #1 0x1c48c0a in non-virtual thunk to autofill::(anonymous
namespace)::TestAutofillDialogController::~TestAutofillDialogController() (in
browser_tests) + 10
    #2 0xd77e93a in TestMessageHandler::~TestMessageHandler() (in browser_tests)
+ 26
    #3 0x60f9bfe in content::SimulateMouseClick(content::WebContents*, int,
WebKit::WebMouseEvent::Button) (in browser_tests) + 574
    #4 0x60fa288 in content::SimulateMouseClick(content::WebContents*, int,
WebKit::WebMouseEvent::Button) (in browser_tests) + 2248
    #5 0x90b4d50 in ChromeBrowserMainParts::PreProfileInit() (in browser_tests)
+ 1040
    #6 0x90b0015 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() (in
browser_tests) + 3205
    #7 0x86fba45 in content::BrowserMainLoop::BrowserThreadsStarted() (in
browser_tests) + 2261
    #8 0x8700bed in non-virtual thunk to
content::BrowserPluginEmbedder::~BrowserPluginEmbedder() (in browser_tests) + 29
    #9 0x86f62fd in content::BrowserMainLoop::~BrowserMainLoop() (in
browser_tests) + 2717
    #10 0x60f995d in content::CrashTab(content::WebContents*) (in browser_tests)
+ 397
    #11 0xd77b21a in InProcessBrowserTest::SetUp() (in browser_tests) + 6170
    #12 0x5081401 in std::string testing::internal::StreamableToString<long
long>(long long const&) (in browser_tests) + 897
    #13 0x5063c61 in testing::TestInfo::~TestInfo() (in browser_tests) + 897
    #14 0x5065e16 in testing::TestCase::Run() (in browser_tests) + 1702
...
==4591==ABORTING

[xiyuan, 2013-05-26 03:45:21]

Committed patchset #1 manually as r202343.