chrome/browser/ui/autofill/autofill_dialog_controller.h - Issue 15961007: Highlight fields we know to be invalid but have no way of locally checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller.h

Issue 15961007: Highlight fields we know to be invalid but have no way of locally checking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller.h b/chrome/browser/ui/autofill/autofill_dialog_controller.h

index b0ea080ef3c62d27edf2a149e3b3075d36007b40..890e4d73bf6647bf30522005861c69992f34375b 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller.h

@@ -38,8 +38,9 @@ namespace autofill {

class AutofillDialogController {

public:

enum ValidationType {

Evan Stade 2013/05/31 23:06:45 this belongs in autofill_dialog_types.h

Dan Beam 2013/06/01 00:23:06 Done.

- VALIDATE_EDIT, // validate user edits. Allow for empty fields.

- VALIDATE_FINAL, // Full form validation. Mandatory fields can't be empty.

+ VALIDATE_SELECT, // Validate existing suggestions (card might've expired).

Evan Stade 2013/05/31 23:06:45 I can't see the link between VALIDATE_SELECT and t

Dan Beam 2013/06/01 00:23:06 Done.

+ VALIDATE_EDIT, // Validate user edits. Allow for empty fields.

+ VALIDATE_FINAL, // Full form validation. Mandatory fields can't be empty.

};

// Strings -------------------------------------------------------------------