Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5785)

Unified Diff: chrome/common/extensions/features/permission_feature.cc

Issue 15961006: Regenerate Extensions API bindings when optional permissions change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/extensions/dispatcher.h » ('j') | chrome/renderer/extensions/dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/permission_feature.cc
diff --git a/chrome/common/extensions/features/permission_feature.cc b/chrome/common/extensions/features/permission_feature.cc
index 5fa2ba2ec8373f34b606155718979413f476148b..801ed95955b7d3eca22c2aa3307b71dbe5404ea7 100644
--- a/chrome/common/extensions/features/permission_feature.cc
+++ b/chrome/common/extensions/features/permission_feature.cc
@@ -27,10 +27,8 @@ Feature::Availability PermissionFeature::IsAvailableToContext(
if (!availability.is_available())
return availability;
- // Optional permissions need to be checked so an API will not be set to
- // undefined forever, when it could just need optional permissions.
if (extension && !extension->HasAPIPermission(name()) &&
- !PermissionsData::GetOptionalPermissions(extension)->
+ !PermissionsData::GetActivePermissions(extension)->
not at google - send to devlin 2013/06/05 19:03:44 you can just remove this, HasAPIPermission checks
cduvall 2013/06/05 23:27:59 Done.
HasAnyAccessToAPI(name())) {
return CreateAvailability(NOT_PRESENT, extension->GetType());
}
« no previous file with comments | « no previous file | chrome/renderer/extensions/dispatcher.h » ('j') | chrome/renderer/extensions/dispatcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698