Issue 15961005: move webkit/glue/cpp_* -> webkit/renderer/

Issue 15961005: move webkit/glue/cpp_* -> webkit/renderer/ (Closed)

Created:
7 years, 6 months ago by scottmg

Modified:
7 years, 6 months ago

Reviewers:
jamesr, darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

move webkit/glue/cpp_* -> webkit/renderer/ TBR=jamesr@chromium.org BUG=239107 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203189

Patch Set 2 : renderer/ not child/ #

Total comments: 2

Patch Set 3 : remove copypasta #

Patch Set 4 : fix test targets #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -1596 lines)			Patch
M	chrome/chrome_renderer.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/external_host_bindings.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/plugins/plugin_placeholder.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_renderer.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3	5 chunks	+5 lines, -3 lines	0 comments	Download
M	content/renderer/cpp_bound_class_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/dom_automation_controller.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/stats_collection_controller.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	webkit/glue/cpp_binding_example.h	View		1 chunk	+0 lines, -82 lines	0 comments	Download
D	webkit/glue/cpp_binding_example.cc	View		1 chunk	+0 lines, -137 lines	0 comments	Download
D	webkit/glue/cpp_bound_class.h	View		1 chunk	+0 lines, -147 lines	0 comments	Download
D	webkit/glue/cpp_bound_class.cc	View		1 chunk	+0 lines, -329 lines	0 comments	Download
D	webkit/glue/cpp_variant.h	View		1 chunk	+0 lines, -116 lines	0 comments	Download
D	webkit/glue/cpp_variant.cc	View		1 chunk	+0 lines, -267 lines	0 comments	Download
D	webkit/glue/cpp_variant_unittest.cc	View		1 chunk	+0 lines, -494 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	2 chunks	+28 lines, -4 lines	0 comments	Download
A +	webkit/renderer/cpp_binding_example.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A +	webkit/renderer/cpp_binding_example.cc	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	webkit/renderer/cpp_bound_class.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	webkit/renderer/cpp_bound_class.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	webkit/renderer/cpp_variant.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	webkit/renderer/cpp_variant.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
A +	webkit/renderer/cpp_variant_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

scottmg

Hmm, actually ignore for now. I see it should probably just be webkit/renderer/ now.

7 years, 6 months ago (2013-05-29 23:24:09 UTC) #2

jamesr

On 2013/05/29 23:24:09, scottmg wrote: > Hmm, actually ignore for now. I see it should ...

7 years, 6 months ago (2013-05-29 23:29:42 UTC) #3

jamesr

lgtm https://codereview.chromium.org/15961005/diff/5001/webkit/glue/webkit_glue.gypi File webkit/glue/webkit_glue.gypi (right): https://codereview.chromium.org/15961005/diff/5001/webkit/glue/webkit_glue.gypi#newcode166 webkit/glue/webkit_glue.gypi:166: '<(DEPTH)/ui/ui.gyp:ui_resources', i don't think the cpp_binding stuff needs ...

7 years, 6 months ago (2013-05-29 23:42:44 UTC) #5

scottmg

7 years, 6 months ago (2013-05-30 18:49:01 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 manually as r203189 (presubmit successful).

Expand Messages | Collapse Messages