Issue 159608: Merge 21988 - Fix crash in client_socket_pool_base.cc....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159608: Merge 21988 - Fix crash in client_socket_pool_base.cc.... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/branches/196/src/

Visibility:
Public.

Merge 21988 - Fix crash in client_socket_pool_base.cc. The CHECK that was being hit showed a real problem: group's IsEmpty should take into account the pending requests queue too. I also made IsEmpty check for connecting requests queue emptiness, so we can be sure that IsEmpty really means empty. TEST=Added a regression test ClientSocketPoolBaseTest.GroupWithPendingRequestsIsNotEmpty to net_unittests. http://crbug.com/17985 Review URL: http://codereview.chromium.org/159597 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22005

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -6 lines)			Patch
MM	net/socket/client_socket_pool_base.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
MM	net/socket/client_socket_pool_base.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
MM	net/socket/client_socket_pool_base_unittest.cc	View	2 chunks	+71 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

11 years, 4 months ago (2009-07-29 22:30:18 UTC) #2

LGTM. In case of any problems with the socket limiting code, please assign bugs
to me, and cc wtc, willchan and eroman.