Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 1596018: Added support for HTML5 progress element. (Closed)

Created:
9 years, 10 months ago by gmorrita
Modified:
8 years, 9 months ago
Reviewers:
tkent, tony, Peter Kasting
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org, dpranke+watch_chromium.org
Visibility:
Public.

Description

Added support for HTML5 progress element. WebKit side of this change is on http://webkit.org/b/37308 .

Patch Set 1 #

Total comments: 5

Patch Set 2 : Updated to took the feedback, aligning webkit-side change #

Patch Set 3 : just sync the change of webkit side. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -5 lines) Patch
M gfx/native_theme_win.h View 1 2 4 chunks +10 lines, -1 line 0 comments Download
M gfx/native_theme_win.cc View 1 2 5 chunks +51 lines, -1 line 0 comments Download
M webkit/glue/webthemeengine_impl_win.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webthemeengine_impl_win.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webthemecontrol.h View 4 chunks +9 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webthemecontrol.cc View 2 chunks +24 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_webthemeengine.h View 2 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webthemeengine.cc View 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tony
Some small style nits. pkasting would be a good actual reviewer. http://codereview.chromium.org/1596018/diff/1/4 File webkit/glue/webthemeengine_impl_win.cc (right): ...
9 years, 10 months ago (2010-04-09 08:27:54 UTC) #1
tkent
http://codereview.chromium.org/1596018/diff/1/4 File webkit/glue/webthemeengine_impl_win.cc (right): http://codereview.chromium.org/1596018/diff/1/4#newcode124 webkit/glue/webthemeengine_impl_win.cc:124: gfx::NativeTheme::instance()->PaintProgressBar( Do not use NativeTheme here. The appearance of ...
9 years, 10 months ago (2010-04-09 08:44:24 UTC) #2
tkent
http://codereview.chromium.org/1596018/diff/1/4 File webkit/glue/webthemeengine_impl_win.cc (right): http://codereview.chromium.org/1596018/diff/1/4#newcode124 webkit/glue/webthemeengine_impl_win.cc:124: gfx::NativeTheme::instance()->PaintProgressBar( > Do not use NativeTheme here. > The ...
9 years, 10 months ago (2010-04-09 08:48:19 UTC) #3
gmorrita
Hi. WebKit side was landed: https://bugs.webkit.org/show_bug.cgi?id=37308 Could anyone give me a review, and land this ...
9 years, 9 months ago (2010-05-12 08:59:14 UTC) #4
tkent
The patch has some lint errors. You can check them by "gcl presubmit xxx" or ...
9 years, 9 months ago (2010-05-12 09:18:03 UTC) #5
gmorrita
9 years, 9 months ago (2010-05-12 09:54:29 UTC) #6
On 2010/05/12 09:18:03, Kent Tamura wrote:
> The patch has some lint errors. You can check them by "gcl presubmit xxx" or
> "Lint" column of the patch set table.
> Please fix them.
Thank you for pointing this out. I didn't noticed that.
I fixed them and uploaded it to http://codereview.chromium.org/1988012
Sorry for inconvenience. I lost the repository that tracks this review.

Powered by Google App Engine
This is Rietveld 408576698