Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 15960018: Update pnacl binutils DEPS and enable mips support in binutils (Closed)

Created:
7 years, 6 months ago by Derek Schuff
Modified:
7 years, 6 months ago
Reviewers:
Mark Seaborn, petarj
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update pnacl binutils DEPS and enable mips support in binutils This brings in support for MIPS currently under review in upstream binutils: be24de8 [MIPS] Add support for mips-nacl in bfd 76854aa [MIPS] Add support for MIPS target in gold It also enables it in build.sh in the binutils build. R=mseaborn@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11497

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M pnacl/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M pnacl/build.sh View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
7 years, 6 months ago (2013-06-06 01:04:41 UTC) #1
Mark Seaborn
LGTM. Can you list the binutils changes being pulled in in the commit message, please?
7 years, 6 months ago (2013-06-06 04:29:07 UTC) #2
Derek Schuff
7 years, 6 months ago (2013-06-06 22:14:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r11497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698