Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 15960015: Build SkImageDecoder_empty.cpp (Closed)

Created:
7 years, 6 months ago by scroggo
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Build SkImageDecoder_empty.cpp Allows Skia's core.gypi to include SkImage implementation files without requiring chromium to build Skia's images project. See https://codereview.chromium.org/15806010/ for the related Skia changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M skia/skia.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scroggo
7 years, 6 months ago (2013-05-28 21:59:43 UTC) #1
robertphillips
lgtm
7 years, 6 months ago (2013-05-28 23:09:08 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-05-30 13:35:45 UTC) #3
scroggo
7 years, 6 months ago (2013-05-30 13:38:04 UTC) #4
f(malita)
lgtm
7 years, 6 months ago (2013-05-30 13:39:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scroggo@google.com/15960015/1
7 years, 6 months ago (2013-05-30 13:39:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=45250
7 years, 6 months ago (2013-05-30 15:52:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scroggo@google.com/15960015/1
7 years, 6 months ago (2013-05-30 20:18:56 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 21:54:05 UTC) #9
Message was sent while issue was closed.
Change committed as 203234

Powered by Google App Engine
This is Rietveld 408576698