net/socket/client_socket_pool_base.h - Issue 159597: Fix crash in client_socket_pool_base.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base.h

Issue 159597: Fix crash in client_socket_pool_base.cc. (Closed)

Patch Set: add test for late binding scenario Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool_base.h

diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h

index 36281b478f0b0a6533bc3af419a833090bc106e0..21cd642a1fd2a8fc401ffe33a18164ec457a975b 100644

--- a/net/socket/client_socket_pool_base.h

+++ b/net/socket/client_socket_pool_base.h

@@ -196,7 +196,8 @@ class ClientSocketPoolBase

Group() : active_socket_count(0) {}

bool IsEmpty() const {

- return active_socket_count == 0 && idle_sockets.empty() && jobs.empty();

+ return active_socket_count == 0 && idle_sockets.empty() && jobs.empty() &&

+ pending_requests.empty() && connecting_requests.empty();

}

bool HasAvailableSocketSlot(int max_sockets_per_group) const {