Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 15959012: cc: Make all layer recursion use CallFunctionForSubtree (Closed)

Created:
7 years, 6 months ago by enne (OOO)
Modified:
7 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Make all layer recursion use CallFunctionForSubtree This is mostly a cleanup that I noticed while doing other code. The behavior change here is that SetNeedsDisplay and DidBecomeActive is now called for all mask and replica layers. Also, refactor CallFunctionForSubtree so that both functors and functions can be passed to it. As no uses in the codebase actually needed function objects with state, turn them all into simpler static functions. R=danakj@chromium.org BUG=239614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204221

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : DidBeginTracing changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -88 lines) Patch
M cc/trees/layer_tree_host.cc View 1 5 chunks +31 lines, -44 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 2 chunks +10 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 5 chunks +25 lines, -30 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
7 years, 6 months ago (2013-05-31 00:17:16 UTC) #1
danakj
LGTM
7 years, 6 months ago (2013-06-04 17:36:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/15959012/3001
7 years, 6 months ago (2013-06-04 17:37:17 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-04 18:01:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/15959012/19001
7 years, 6 months ago (2013-06-04 22:16:26 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 10:28:20 UTC) #6
Message was sent while issue was closed.
Change committed as 204221

Powered by Google App Engine
This is Rietveld 408576698