Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 15959006: Deprecate FileSystemMountPointProvider::GetFileSystemRootPathOnFileThread (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, vandebo (ex-Chrome), kinaba, tommycli
Visibility:
Public.

Description

Deprecate FileSystemMountPointProvider::GetFileSystemRootPathOnFileThread This was initially introduced to get ExternalFileSystem's local mount root path, but accessing MountPointProvider from lower-layer FileUtil module looks ugly. This patch: - Deprecate FileSystemMountPointProvider::GetFileSystemRootPathOnFileThread - Add FileSystemOperationContext::root_path() instead for passing root path BUG=241701 TEST=Moved tests from content_unittests:FileSystemMountPointProviderTest.* to content_unittests:SandboxMountPointProviderTest.* R=bauerb@chromium.org, michaeln@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202776

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -114 lines) Patch
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M webkit/browser/chromeos/fileapi/cros_mount_point_provider.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M webkit/browser/chromeos/fileapi/cros_mount_point_provider.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_context.h View 1 4 chunks +15 lines, -9 lines 0 comments Download
M webkit/browser/fileapi/file_writer_delegate_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_cross_operation_unittest.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/local_file_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_util_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_test_helper.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_test_helper.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M webkit/browser/fileapi/test_mount_point_provider.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/test_mount_point_provider.cc View 1 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinuko
PTL
7 years, 7 months ago (2013-05-24 13:04:20 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-27 08:26:52 UTC) #2
kinuko
mkwst@: can you do OWNER review for chrome/browser/browsing_data change?
7 years, 7 months ago (2013-05-27 08:39:46 UTC) #3
kinuko
On 2013/05/27 08:39:46, kinuko wrote: > mkwst@: can you do OWNER review for chrome/browser/browsing_data change? ...
7 years, 7 months ago (2013-05-27 10:32:24 UTC) #4
kinuko
bauerb@: can you do OWNER review for chrome/browser/browsing_data change?
7 years, 6 months ago (2013-05-28 14:43:51 UTC) #5
Bernhard Bauer
LGTM! (Feel free to TBR signature updates like these).
7 years, 6 months ago (2013-05-28 16:03:10 UTC) #6
michaeln
chrome/browser lgtm
7 years, 6 months ago (2013-05-28 19:05:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/15959006/21001
7 years, 6 months ago (2013-05-29 02:34:41 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-05-29 03:07:05 UTC) #9
kinuko
7 years, 6 months ago (2013-05-29 04:25:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r202776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698