dart2js cps: Fix codegen for instanceof checks.

dart2js cps: Fix codegen for instanceof checks.

With certain optimizations disabled the codegen would sometimes register
an unresolved class as being instantiated.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0b157e29633d3f67aba8fbba3a7eb12c1de16492

[asgerf, 2016-01-16 00:46:23]

asgerf@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-01-16 00:50:40]

https://codereview.chromium.org/1595783002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/1595783002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:445:
tryRegisterInstanceofCheck(clazz)) {
what would the code below generate when this is false?

[asgerf, 2016-01-16 01:05:13]

https://codereview.chromium.org/1595783002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/1595783002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:445:
tryRegisterInstanceofCheck(clazz)) {
On 2016/01/16 00:50:40, Siggi Cherem (dart-lang) wrote:
> what would the code below generate when this is false?

A call to a static checkSubtype method. That method is pretty slow but that case
really should not happen in practice anyway.

[Siggi Cherem (dart-lang), 2016-01-16 01:08:21]

lgtm

[asgerf, 2016-01-19 22:17:44]

Description was changed from

==========
dart2js cps: Fix codegen for instanceof checks.

With certain optimizations disabled the codegen would sometimes register
an unresolved class as being instantiated.

BUG=
==========

to

==========
dart2js cps: Fix codegen for instanceof checks.

With certain optimizations disabled the codegen would sometimes register
an unresolved class as being instantiated.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0b157e29633d3f67aba8fbba3a7eb12c1de16492
==========

[asgerf, 2016-01-19 22:17:45]

Committed patchset #1 (id:1) manually as
0b157e29633d3f67aba8fbba3a7eb12c1de16492 (presubmit successful).