Issue 159573: Nice and easy fix for the media clock interpolating past the duration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159573: Nice and easy fix for the media clock interpolating past the duration. (Closed)

Created:
11 years, 4 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Nice and easy fix for the media clock interpolating past the duration. I considered adding duration to Clock itself, but that felt like it would pollute Clock's simple purposes of keeping track of time. Furthermore, by keeping duration checking in PipelineImpl we can handle future scenarios such as streaming media where clock really should run forever. BUG=16508 TEST=currentTime should never exceed duration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21937

Patch Set 1 #

Patch Set 2 : Typos #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
M	media/base/mock_filters.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	media/base/pipeline_impl_unittest.cc	View		6 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages