Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp

Issue 1595713003: Make ReadableStreamOperations use ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ReadableStreamOperations.h" 5 #include "bindings/core/v8/ReadableStreamOperations.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8BindingMacros.h" 9 #include "bindings/core/v8/V8BindingMacros.h"
10 10
(...skipping 13 matching lines...) Expand all
24 } 24 }
25 25
26 template <size_t N> 26 template <size_t N>
27 v8::MaybeLocal<v8::Value> call(ScriptState* scriptState, const char* name, v8::L ocal<v8::Value>(&args)[N]) 27 v8::MaybeLocal<v8::Value> call(ScriptState* scriptState, const char* name, v8::L ocal<v8::Value>(&args)[N])
28 { 28 {
29 return call(scriptState, name, N, args); 29 return call(scriptState, name, N, args);
30 } 30 }
31 31
32 } // namespace 32 } // namespace
33 33
34 ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, v8::Lo cal<v8::Value> stream, ExceptionState& es) 34 ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, Script Value stream, ExceptionState& es)
35 { 35 {
36 ASSERT(isReadableStream(scriptState, stream)); 36 ASSERT(isReadableStream(scriptState, stream));
37 37
38 v8::TryCatch block(scriptState->isolate()); 38 v8::TryCatch block(scriptState->isolate());
39 v8::Local<v8::Value> args[] = { stream }; 39 v8::Local<v8::Value> args[] = { stream.v8Value() };
40 ScriptValue result(scriptState, call(scriptState, "AcquireReadableStreamRead er", args)); 40 ScriptValue result(scriptState, call(scriptState, "AcquireReadableStreamRead er", args));
41 if (block.HasCaught()) 41 if (block.HasCaught())
42 es.rethrowV8Exception(block.Exception()); 42 es.rethrowV8Exception(block.Exception());
43 return result; 43 return result;
44 } 44 }
45 45
46 bool ReadableStreamOperations::isReadableStream(ScriptState* scriptState, v8::Lo cal<v8::Value> value) 46 bool ReadableStreamOperations::isReadableStream(ScriptState* scriptState, Script Value value)
47 { 47 {
48 if (!value->IsObject()) 48 if (!value.isObject())
49 return false; 49 return false;
50 50
51 v8::Local<v8::Value> args[] = { value }; 51 v8::Local<v8::Value> args[] = { value.v8Value() };
52 return v8CallOrCrash(call(scriptState, "IsReadableStream", args))->ToBoolean ()->Value(); 52 return v8CallOrCrash(call(scriptState, "IsReadableStream", args))->ToBoolean ()->Value();
53 } 53 }
54 54
55 bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, v8::Local<v 8::Value> stream) 55 bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, ScriptValue stream)
56 { 56 {
57 ASSERT(isReadableStream(scriptState, stream)); 57 ASSERT(isReadableStream(scriptState, stream));
58 58
59 v8::Local<v8::Value> args[] = { stream }; 59 v8::Local<v8::Value> args[] = { stream.v8Value() };
60 return v8CallOrCrash(call(scriptState, "IsReadableStreamDisturbed", args))-> ToBoolean()->Value(); 60 return v8CallOrCrash(call(scriptState, "IsReadableStreamDisturbed", args))-> ToBoolean()->Value();
61 } 61 }
62 62
63 bool ReadableStreamOperations::isLocked(ScriptState* scriptState, v8::Local<v8:: Value> stream) 63 bool ReadableStreamOperations::isLocked(ScriptState* scriptState, ScriptValue st ream)
64 { 64 {
65 ASSERT(isReadableStream(scriptState, stream)); 65 ASSERT(isReadableStream(scriptState, stream));
66 66
67 v8::Local<v8::Value> args[] = { stream }; 67 v8::Local<v8::Value> args[] = { stream.v8Value() };
68 return v8CallOrCrash(call(scriptState, "IsReadableStreamLocked", args))->ToB oolean()->Value(); 68 return v8CallOrCrash(call(scriptState, "IsReadableStreamLocked", args))->ToB oolean()->Value();
69 } 69 }
70 70
71 bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, v8::Local<v8::Value> value) 71 bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, ScriptValue value)
72 { 72 {
73 if (!value->IsObject()) 73 if (!value.isObject())
74 return false; 74 return false;
75 75
76 v8::Local<v8::Value> args[] = { value }; 76 v8::Local<v8::Value> args[] = { value.v8Value() };
77 return v8CallOrCrash(call(scriptState, "IsReadableStreamReader", args))->ToB oolean()->Value(); 77 return v8CallOrCrash(call(scriptState, "IsReadableStreamReader", args))->ToB oolean()->Value();
78 } 78 }
79 79
80 ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, v8::Local <v8::Value> reader) 80 ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, ScriptVal ue reader)
81 { 81 {
82 ASSERT(isReadableStreamReader(scriptState, reader)); 82 ASSERT(isReadableStreamReader(scriptState, reader));
83 83
84 v8::Local<v8::Value> args[] = { reader }; 84 v8::Local<v8::Value> args[] = { reader.v8Value() };
85 return ScriptPromise::cast(scriptState, v8CallOrCrash(call(scriptState, "Rea dFromReadableStreamReader", args))); 85 return ScriptPromise::cast(scriptState, v8CallOrCrash(call(scriptState, "Rea dFromReadableStreamReader", args)));
86 } 86 }
87 87
88 } // namespace blink 88 } // namespace blink
89 89
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698