Move NaCl related switches to their own file.

chrome/nacl/nacl_switches.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/nacl/nacl_switches.h"
+
+#include "base/base_switches.h"
+#include "base/command_line.h"
+
+namespace switches {
+
+// Disables the bundled PPAPI version of Flash.
+const char kDisableBundledPpapiFlash[]      = "disable-bundled-ppapi-flash";

[Mark Seaborn, 2013/05/29 16:03:13]

This has nothing to do with NaCl.  Flash doesn't run under NaCl.

Same for the other "ppapi-flash" options below.

+
+// Runs the Native Client inside the renderer process and enables GPU plugin
+// (internally adds lEnableGpuPlugin to the command line).
+const char kEnableNaCl[]                    = "enable-nacl";
+
+// Enables debugging via RSP over a socket.
+const char kEnableNaClDebug[]               = "enable-nacl-debug";
+
+// Enables the installation and usage of Portable Native Client.
+const char kEnablePnacl[]                   = "enable-pnacl";
+
+// Causes the process to run as a NativeClient broker
+// (used for launching NaCl loader processes on 64-bit Windows).
+const char kNaClBrokerProcess[]             = "nacl-broker";
+
+// Uses NaCl manifest URL to choose whether NaCl program will be debugged by
+// debug stub.
+// Switch value format: [!]pattern1,pattern2,...,patternN. Each pattern uses
+// the same syntax as patterns in Chrome extension manifest. The only difference
+// is that * scheme matches all schemes instead of matching only http and https.
+// If the value doesn't start with !, a program will be debugged if manifest URL
+// matches any pattern. If the value starts with !, a program will be debugged
+// if manifest URL does not match any pattern.
+const char kNaClDebugMask[]                 = "nacl-debug-mask";
+
+// Native Client GDB debugger for loader. It needs switches calculated
+// at run time in order to work correctly. That's why NaClLoadCmdPrefix
+// flag can't be used.
+const char kNaClGdb[]                       = "nacl-gdb";
+
+// GDB script to pass to the nacl-gdb debugger at startup.
+const char kNaClGdbScript[]                 = "nacl-gdb-script";
+
+// Causes the process to run as a NativeClient loader.
+const char kNaClLoaderProcess[]             = "nacl-loader";
+
+// On POSIX only: the contents of this flag are prepended to the nacl-loader
+// command line. Useful values might be "valgrind" or "xterm -e gdb --args".
+const char kNaClLoaderCmdPrefix[]           = "nacl-loader-cmd-prefix";
+
+// Overrides the path to the location that PNaCl is installed.
+const char kPnaclDir[]                      = "pnacl-dir";
+
+// Forces the PPAPI version of Flash (if it's being used) to run in the
+// renderer process rather than in a separate plugin process.
+const char kPpapiFlashInProcess[]           = "ppapi-flash-in-process";
+
+// Use the PPAPI (Pepper) Flash found at the given path.
+const char kPpapiFlashPath[]                = "ppapi-flash-path";
+
+// Report the given version for the PPAPI (Pepper) Flash. The version should be
+// numbers separated by '.'s (e.g., "12.3.456.78"). If not specified, it
+// defaults to "10.2.999.999".
+const char kPpapiFlashVersion[]             = "ppapi-flash-version";
+
+// Runs the security test for the NaCl loader sandbox.
+const char kTestNaClSandbox[]               = "test-nacl-sandbox";
+}  // namespace switches

[Mark Seaborn, 2013/05/29 16:03:13]

Nit: Add empty line before this for consistency with 'namespace switches {'
above

[yael.aharon1, 2013/05/29 16:13:37]

Done.